-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Postgres ranges rebuild #1017
Postgres ranges rebuild #1017
Conversation
…gress. Includes some product->layer name refactoring.
… and passing mypy.
for more information, see https://pre-commit.ci
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop-1.9 #1017 +/- ##
===============================================
- Coverage 93.77% 93.59% -0.19%
===============================================
Files 46 46
Lines 6573 6616 +43
===============================================
+ Hits 6164 6192 +28
- Misses 409 424 +15
|
Thanks Peter. That was a really helpful review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're in opposite time zones so me blocking progress is probably worse than any errors slipping in, go ahead and merge according to your own judgement.
I don't know anything about the code base, but besides the assignment to TYPE_CHECKING
, the changes look reasonable to me.
Complete rewrite of the OWS schema management:
Still in draft to get the integration tests running on github again and check test coverage - some documentation updates also required.
📚 Documentation preview 📚: https://datacube-ows--1017.org.readthedocs.build/en/1017/