Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Postgis driver support #1032

Merged
merged 36 commits into from
Jul 11, 2024
Merged

Postgis driver support #1032

merged 36 commits into from
Jul 11, 2024

Conversation

SpacemanPaul
Copy link
Contributor

@SpacemanPaul SpacemanPaul commented Jul 3, 2024

Support for postgis driver. Uses native postgis tables for dataset search and populating range tables.

Multidb test framework - one postgres test index and one postgis one.

Wow, it's actually working now! Need to update documentation, review test coverage and probably some code cleanup before ready for review, but getting very close.


📚 Documentation preview 📚: https://datacube-ows--1032.org.readthedocs.build/en/1032/

pre-commit-ci bot and others added 26 commits June 13, 2024 10:36
* [pre-commit.ci] pre-commit autoupdate

updates:
- [github.com/PyCQA/pylint: v3.1.0 → v3.2.3](pylint-dev/pylint@v3.1.0...v3.2.3)

* Lintage for Pylint upgrade.

* Non-pre-commit pylint too old.

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Paul Haesler <[email protected]>

(cherry picked from commit bca8a8e)
Copy link

codecov bot commented Jul 9, 2024

Codecov Report

Attention: Patch coverage is 91.85668% with 25 lines in your changes missing coverage. Please review.

Project coverage is 93.24%. Comparing base (722bc6e) to head (4f0b5e0).
Report is 34 commits behind head on develop-1.9.

Files with missing lines Patch % Lines
datacube_ows/index/postgis/product_ranges.py 91.17% 9 Missing ⚠️
datacube_ows/loading.py 86.95% 6 Missing ⚠️
datacube_ows/index/postgis/api.py 94.18% 5 Missing ⚠️
datacube_ows/index/api.py 76.92% 3 Missing ⚠️
datacube_ows/data.py 85.71% 1 Missing ⚠️
datacube_ows/update_ranges_impl.py 88.88% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##           develop-1.9    #1032      +/-   ##
===============================================
- Coverage        93.77%   93.24%   -0.54%     
===============================================
  Files               46       53       +7     
  Lines             6573     6999     +426     
===============================================
+ Hits              6164     6526     +362     
- Misses             409      473      +64     
Files with missing lines Coverage Δ
datacube_ows/feature_info.py 89.36% <100.00%> (+0.05%) ⬆️
datacube_ows/index/postgres/api.py 96.77% <100.00%> (ø)
datacube_ows/index/postgres/product_ranges.py 90.42% <100.00%> (ø)
datacube_ows/index/sql.py 89.06% <100.00%> (ø)
datacube_ows/ows_configuration.py 94.37% <100.00%> (-1.33%) ⬇️
datacube_ows/styles/component.py 93.61% <100.00%> (ø)
datacube_ows/wcs1_utils.py 95.23% <100.00%> (-0.03%) ⬇️
datacube_ows/wcs2_utils.py 91.91% <100.00%> (-0.05%) ⬇️
datacube_ows/data.py 91.44% <85.71%> (-0.05%) ⬇️
datacube_ows/update_ranges_impl.py 86.08% <88.88%> (-4.27%) ⬇️
... and 4 more

... and 3 files with indirect coverage changes

@SpacemanPaul SpacemanPaul marked this pull request as ready for review July 10, 2024 04:00
Ariana-B
Ariana-B previously approved these changes Jul 10, 2024
Copy link

@Ariana-B Ariana-B left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable as far as I can tell, but could probably benefit from some more comments

datacube_ows/index/postgis/product_ranges.py Outdated Show resolved Hide resolved
datacube_ows/index/sql.py Show resolved Hide resolved
@SpacemanPaul SpacemanPaul merged commit 1c22b2c into develop-1.9 Jul 11, 2024
10 checks passed
@SpacemanPaul SpacemanPaul deleted the postgis-driver-support branch July 11, 2024 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants