Changes to materialised view definition to prevent errors on databases with WKT CRSs #1037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SpacemanPaul
force-pushed
the
skip_wkt_in_mvs
branch
from
1dea91a
to
9a1c1d1
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1037 +/- ##
=======================================
Coverage 93.59% 93.59%
=======================================
Files 43 43
Lines 6494 6494
=======================================
Hits 6078 6078
Misses 416 416 |
Ariana-B
approved these changes
Jul 22, 2024
Merged
SpacemanPaul
added a commit
that referenced
this pull request
Aug 1, 2024
* multi-date handler aggregator in ramp styles can now receive raw data (#1033) * First attempt to implement raw data passing. * Fix intermediate array dtype for numpy2 * Basic test. * Wordlist update. * Wordlist update. (cherry picked from commit 41daa21) * Prep for 1.8.41 release. (#1034) * Prep for 1.8.41 release. * Add this PR to HISTORY.rst (cherry picked from commit 6c75bb2) * Dockerfile: fix casing warning (#1035) This fixes the warning: - FromAsCasing: 'as' and 'FROM' keywords' casing do not match (line 2) emitted by recent Docker releases. (cherry picked from commit 955c49d) * Version and top level folder (#1036) * Make 'datacube-ows --version' work. * Autowrap top level in single folder if necessary. * Document top-level folder autowrapping behaviour. * Update integration test translation files. * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Pass auth token to codecov GHA. --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> (cherry picked from commit d71b0ef) * Changes to materialised view definition to prevent errors on databases with WKT CRSs (#1037) * Changes to materialised view definition to prevent errors on databases with WKT CRSs. * Make 'epsg:' checks case insensitive. (cherry picked from commit fb88ea2) * Port of #1039 - custom feature info enhancement. * Resolve 1.8-1.9 cherry-picking conflicts. * Appease the type checking gods. * Remove unused import. * Oops - dropped a line merging ows_configuration.py --------- Co-authored-by: Peter A. Jonsson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #1002, creation of OWS materialised views fails on indexes that contain datasets with WKT-format CRSs, even if the datasets in question belong to products not included in the OWS config.
This PR explicitly excludes non-EPSG CRS datasets from the materialised view. This means that such datasets can NEVER be returned by OWS, but it will at least be able to possible to use OWS for other products in the same index.
Viewing non-EPSG CRS datasets will be possible in 1.9.0, with the new postgis ODC driver.
This (and other CRS-related) limitations of 1.8/postgres OWS are now documented in the README.
📚 Documentation preview 📚: https://datacube-ows--1037.org.readthedocs.build/en/1037/