Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile: remove pg_isready #1057

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

pjonsson
Copy link
Contributor

@pjonsson pjonsson commented Aug 9, 2024

After adding health checks to docker compose,
this command is no longer used anywhere else.


📚 Documentation preview 📚: https://datacube-ows--1057.org.readthedocs.build/en/1057/

After adding health checks to docker compose,
this command is no longer used anywhere else.
Copy link

codecov bot commented Aug 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.64%. Comparing base (8466b07) to head (73732af).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1057   +/-   ##
=======================================
  Coverage   93.64%   93.64%           
=======================================
  Files          43       43           
  Lines        6510     6510           
=======================================
  Hits         6096     6096           
  Misses        414      414           

@pjonsson
Copy link
Contributor Author

pjonsson commented Aug 9, 2024

Edit: #1059 removes the copying along with not installing the test dependencies in the prod image, so that supersedes this PR. I'm most likely busy with other things for the next couple of weeks, so if that PR isn't merged or needs further discussion before merging, I think this PR should be merged in the meantime.

The copy statements seem to originate from #743, and that references GDAL as inspiration. I use GDAL 3.4 which is from late 2021 and that does copy, but it's the extra libraries that were built in the builder image that are copied from the builder, not the content of the deb packages.

I'm pretty sure that dodging the package system confuses Trivy since it can't see that the binary comes from a security patched Debian/Ubuntu package, so the image is flagged as containing more security vulnerabilities than it actually does.

The point of this PR was just to remove the now unused binary, I'll fix the rest of the copying in a separate PR. I suspect that will be a bit of work and I have quite a few other things on my plate, so don't hold the next release while you wait for that PR, the image on current master is strictly better than it was in the previous release and I think that is a win in itself.

@SpacemanPaul SpacemanPaul merged commit 2da24e5 into opendatacube:master Aug 12, 2024
15 checks passed
@SpacemanPaul
Copy link
Contributor

I wouldn't overthink anything done in #743

@pjonsson pjonsson deleted the dockerfile-less-copy branch August 12, 2024 06:39
@SpacemanPaul SpacemanPaul mentioned this pull request Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants