Remove checking against crs valid extent #1076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexgleith
commented
Oct 9, 2024
Comment on lines
+171
to
+173
| if base_extent is None: | ||
| click.echo(f"Layer {layer.name} has no extent in CRS {base_crs}. Skipping.") | ||
| return |
There was a problem hiding this comment.
Not sure this is a good idea, probably needs testing. Empty products were failing in update ranges though.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop-1.9 #1076 +/- ##
===============================================
+ Coverage 93.28% 93.33% +0.05%
===============================================
Files 53 53
Lines 7039 7032 -7
===============================================
- Hits 6566 6563 -3
+ Misses 473 469 -4
|
SpacemanPaul
approved these changes
Oct 9, 2024
| projbbox = starting_box.to_crs(crs).boundingbox | ||
| result[crsid] = sanitise_bbox(projbbox) | ||
| projbbox = starting_box.to_crs(crs).boundingbox | ||
| result[crsid] = sanitise_bbox(projbbox) |
There was a problem hiding this comment.
I can see issues with this, but with the way WMS is defined I'm not sure we can do better.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some code here was doing a similar thing to what we fixed in
datacube-corehere: opendatacube/datacube-core#1635📚 Documentation preview 📚: https://datacube-ows--1076.org.readthedocs.build/en/1076/