For 1 8 36

.pre-commit-config.yaml

@@ -1,6 +1,6 @@
 repos:
 -   repo: https://github.com/pre-commit/pre-commit-hooks
-    rev: v4.4.0
+    rev: v4.5.0
     hooks:
     -   id: check-yaml
     -   id: end-of-file-fixer
@@ -19,7 +19,7 @@ repos:
 #     hooks:
 #     -   id: bandit
 -   repo: https://github.com/PyCQA/pylint
-    rev: v3.0.0a7
+    rev: v3.0.1
     hooks:
       - id: pylint
         args: ["--disable=C,R,W,E1136"]

HISTORY.rst

@@ -7,12 +7,19 @@ History
 
 Datacube-ows version 1.8.x indicates that it is designed work with datacube-core versions 1.8.x.
 
+1.8.36 (2023-10-24)
+-------------------
+
+* Fix Docker image and CI pipeline (#954)
+* Make PYDEV_DEBUG behaviour less counter-intuitive (#955)
+* Update HISTORY.rst and increment default version for release (#956)
+
 1.8.35 (2023-09-01)
 -------------------
 
 Maintenance release.
 
-* Changes to depenency version pins (#983, #942, #948, #949)
+* Changes to dependency version pins (#983, #942, #948, #949)
 
 Includes contributions from @pindge, @emmaai and @SpacemanPaul.
 

datacube_ows/__init__.py

@@ -6,4 +6,4 @@
 try:
     from ._version import version as __version__
 except ImportError:
-    __version__ = "1.8.35+?"
+    __version__ = "1.8.36+?"

datacube_ows/startup_utils.py

@@ -50,10 +50,11 @@ def initialise_ignorable_warnings():
 def initialise_debugging(log=None):
     # PYCHARM Debugging
     if os.environ.get("PYDEV_DEBUG"):
-        import pydevd_pycharm
-        pydevd_pycharm.settrace('172.17.0.1', port=12321, stdoutToServer=True, stderrToServer=True)
-        if log:
-            log.info("PyCharm Debugging enabled")
+        if os.environ["PYDEV_DEBUG"].lower() not in ("no", "false", "f", "n"):
+            import pydevd_pycharm
+            pydevd_pycharm.settrace('172.17.0.1', port=12321, stdoutToServer=True, stderrToServer=True)
+            if log:
+                log.info("PyCharm Debugging enabled")
 
 def before_send(event, hint):
     if 'exc_info' in hint:

docs/environment_variables.rst

@@ -103,7 +103,7 @@ Dev Tools
 ---------
 
 PYDEV_DEBUG:
-    If set, activates PyDev remote debugging.
+    If set to anything other than "n", "f", "no" or "false" (case insensitive), activates PyDev remote debugging.
 
 DEFER_CFG_PARSE:
     If set, the configuration file is not read and parsed at startup.  This

tests/test_startup.py

@@ -82,6 +82,12 @@ def test_initialise_nodebugging(monkeypatch):
     initialise_debugging()
 
 
+def test_initialise_explicit_nodebugging(monkeypatch):
+    monkeypatch.setenv("PYDEV_DEBUG", "no")
+    from datacube_ows.startup_utils import initialise_debugging
+    initialise_debugging()
+
+
 def test_initialise_debugging(monkeypatch):
     monkeypatch.setenv("PYDEV_DEBUG", "YES")
     from datacube_ows.startup_utils import initialise_debugging

wordlist.txt

@@ -138,6 +138,7 @@ ee
 ef
 efd
 eg
+emmaai
 english
 entrypoint
 enum