Label metrics by endpoint not path #978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Metrics are not logs! Currently, OWS pods are exporting ~5k metrics each due to a misconfiguration, unreasonably requiring Prometheus to retain multiple separate time-series per HTTP path. High cardinality information (individual HTTP paths) belong in logs but not metrics. This change makes OWS consistent with datacube-explorer: opendatacube/datacube-explorer@6051dd6
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #978 +/- ##
=======================================
Coverage 93.71% 93.71%
=======================================
Files 43 43
Lines 6479 6479
=======================================
Hits 6072 6072
Misses 407 407
|
omad
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Metrics are not logs!
Currently, OWS pods are exporting ~5k metrics each due to a misconfiguration, unreasonably requiring Prometheus to retain multiple separate time-series per HTTP path. High cardinality information (individual HTTP paths) belongs in logs but not metrics.
This change makes OWS consistent with datacube-explorer:
opendatacube/datacube-explorer@6051dd6
📚 Documentation preview 📚: https://datacube-ows--978.org.readthedocs.build/en/978/