Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly use the modern sphinx_rtd_theme doc theme #354

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

jeremyh
Copy link
Collaborator

@jeremyh jeremyh commented Jun 25, 2024

The docs have reverted to a very old theme (I don't know why... did the default change?).

Explicitly set the modern rtd theme.

A demo build of this change is here: https://jez-eod3.readthedocs.io/en/latest/

This used to be the default, but seems to have changed.
@jeremyh jeremyh marked this pull request as ready for review June 25, 2024 05:00
@jeremyh jeremyh changed the title Explicitly use the sphinx_rtd_theme Explicitly use the sphinx_rtd_theme doc theme Jun 25, 2024
@jeremyh jeremyh changed the title Explicitly use the sphinx_rtd_theme doc theme Explicitly use the sphinx_rtd_theme doc theme Jun 25, 2024
@jeremyh jeremyh changed the title Explicitly use the sphinx_rtd_theme doc theme Explicitly use the modern sphinx_rtd_theme doc theme Jun 25, 2024
@jeremyh
Copy link
Collaborator Author

jeremyh commented Jun 25, 2024

Previously reported by Robbi in #333

Copy link
Contributor

@robbibt robbibt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks so much better! Only comment is that the content is currently a bit cramped on the left hand side, but not a major issue.

image

@jeremyh jeremyh merged commit b9b4a31 into opendatacube:develop Jun 25, 2024
5 checks passed
@jeremyh jeremyh deleted the doc-theme branch June 25, 2024 05:18
@jeremyh
Copy link
Collaborator Author

jeremyh commented Jun 25, 2024

Looks so much better! Only comment is that the content is currently a bit cramped on the left hand side, but not a major issue.

That's odd that it's slightly different to the old default...

@jeremyh
Copy link
Collaborator Author

jeremyh commented Jun 25, 2024

It's now the latest version of docs, but this wont, unfortunately, fix the previous tagged release build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants