This repository has been archived by the owner on Sep 10, 2022. It is now read-only.
Build spark/hadoop from source and pip install the local package #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LaVLaS
force-pushed
the
fix/thoth-station_spark_build
branch
from
e4087ea
to
e704e4e
Compare
LaVLaS
force-pushed
the
fix/thoth-station_spark_build
branch
from
e704e4e
to
21f9196
Compare
LaVLaS
changed the title
rimolive
reviewed
May 24, 2021
| ARG SPARK_SOURCE_REPO=https://github.com/apache/spark.git | ||
| ARG SPARK_SOURCE_REPO_BRANCH=v${SPARK_VERSION} | ||
| ARG SPARK_SOURCE_REPO_TARGET_DIR=spark | ||
| ARG SPARK_BUILD_ARGS="-Phive -Phive-thriftserver -Pkubernetes -Dhadoop.version=${HADOOP_VERSION}" |
There was a problem hiding this comment.
Why do you think -P hive-thriftserver is necessary? Will this image replace the images in Data Catalog?
There was a problem hiding this comment.
The spark build args are from the examples on Apache Spark docs. If there is a reason to remove hive-thriftserver that won't break the ODH data engineering workflow then I have no objections from removing it as a default arg. Otherwise, you can remove it at build time by overriding SPARK_BUILD_ARGS
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the python-3.6 Dockerfile to build a custom spark & hadoop binary from source and pip install the python wheel so that it works with the default
PYTHONPATHCloses #6