Skip to content

Commit

Permalink
Do not save logs for TestRayCluster
Browse files Browse the repository at this point in the history
It is because of RHODS-12857.
  • Loading branch information
jiripetrlik committed Nov 13, 2023
1 parent 6cab591 commit c3a9ebe
Showing 1 changed file with 9 additions and 6 deletions.
15 changes: 9 additions & 6 deletions tests/integration/ray_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -108,13 +108,16 @@ func TestRayCluster(t *testing.T) {
test.Eventually(support.Route(test, dashboardRoute.Namespace, dashboardRoute.Name), support.TestTimeoutLong).
Should(WithTransform(support.ConditionStatus(routev1.RouteAdmitted), Equal(corev1.ConditionTrue)))

// Retrieve dashboard hostname
dashboard, err := test.Client().Route().RouteV1().Routes(namespace.Name).Get(test.Ctx(), dashboardRoute.Name, metav1.GetOptions{})
test.Expect(err).NotTo(HaveOccurred())
dashboardHostname := dashboard.Status.Ingress[0].Host
/*
Should be uncommented when RHODS-12857 is fixed
// Retrieve dashboard hostname
dashboard, err := test.Client().Route().RouteV1().Routes(namespace.Name).Get(test.Ctx(), dashboardRoute.Name, metav1.GetOptions{})
test.Expect(err).NotTo(HaveOccurred())
dashboardHostname := dashboard.Status.Ingress[0].Host
rayClient := support.NewRayClusterClient(url.URL{Scheme: "http", Host: dashboardHostname})
defer support.WriteRayJobLogs(test, rayClient, rayJob.Namespace, rayJob.Name)
rayClient := support.NewRayClusterClient(url.URL{Scheme: "http", Host: dashboardHostname})
defer support.WriteRayJobLogs(test, rayClient, rayJob.Namespace, rayJob.Name)
*/

test.T().Logf("Waiting for RayJob %s/%s to complete", rayJob.Namespace, rayJob.Name)
// Will be removed when RHODS-12857 is fixed
Expand Down

0 comments on commit c3a9ebe

Please sign in to comment.