Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use busybox from quay.io #152

Closed
wants to merge 1 commit into from

Conversation

jiripetrlik
Copy link
Contributor

Use busybox from quay.io instead of from Docker hub. Version should stay the same.

Copy link

openshift-ci bot commented Nov 7, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from jiripetrlik. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@@ -319,7 +319,7 @@ func createRayCluster(test support.Test, namespace string, mnist *corev1.ConfigM
InitContainers: []corev1.Container{
{
Name: "init-myservice",
Image: "busybox:1.28",
Image: "quay.io/project-codeflare/busybox:1.28",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason we're using 1.28 and not 1.36 which appears to be the latest one we've got in quay?

Copy link

@dimakis dimakis Nov 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dimakis Yes, true you are right. Updated to 1.36.

Copy link

openshift-ci bot commented Nov 8, 2023

@jiripetrlik: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-odh-dw 43cdf50 link true /test e2e-odh-dw

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jiripetrlik
Copy link
Contributor Author

Replaced by #153

@jiripetrlik jiripetrlik closed this Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants