-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP - Update to use codeflare-common repo functions + update to RayV1 #156
WIP - Update to use codeflare-common repo functions + update to RayV1 #156
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
d27d327
to
80b4749
Compare
@ChristianZaccaria: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It may be we don't want to maintain those tests in the future, as they've been moved over to CF/CFO repository with project-codeflare/codeflare-operator#386. I think the Kuberay test has yet to be moved, but we may want to work on the later, rather than investing any further in that repository. WDYT?
@astefanutti I agree, it's better to scrap this PR then. In the meantime, the only thing I really need is to add some cluster roles and CRB to a test, just to test out the CI on this PR: openshift/release#45214 I made this PR here that just adds those cluster roles and CRB: #157 |
@ChristianZaccaria sounds good. /cc @sutaakar |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Closing this PR as discussed in the comments. |
Description
TestMCADRay
test.How Has This Been Tested?
Merge criteria: