Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP - Update to use codeflare-common repo functions + update to RayV1 #156

Conversation

ChristianZaccaria
Copy link
Contributor

Description

How Has This Been Tested?

  • e2e tests should pass.

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Copy link

openshift-ci bot commented Nov 13, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign tedhtchang for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

openshift-ci bot commented Nov 13, 2023

@ChristianZaccaria: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-odh-dw 977bed1 link true /test e2e-odh-dw

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Contributor

@astefanutti astefanutti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may be we don't want to maintain those tests in the future, as they've been moved over to CF/CFO repository with project-codeflare/codeflare-operator#386. I think the Kuberay test has yet to be moved, but we may want to work on the later, rather than investing any further in that repository. WDYT?

@ChristianZaccaria
Copy link
Contributor Author

It may be we don't want to maintain those tests in the future, as they've been moved over to CF/CFO repository with project-codeflare/codeflare-operator#386. I think the Kuberay test has yet to be moved, but we may want to work on the later, rather than investing any further in that repository. WDYT?

@astefanutti I agree, it's better to scrap this PR then. In the meantime, the only thing I really need is to add some cluster roles and CRB to a test, just to test out the CI on this PR: openshift/release#45214

I made this PR here that just adds those cluster roles and CRB: #157

@astefanutti
Copy link
Contributor

@astefanutti I agree, it's better to scrap this PR then. In the meantime, the only thing I really need is to add some cluster roles and CRB to a test, just to test out the CI on this PR: openshift/release#45214

I made this PR here that just adds those cluster roles and CRB: #157

@ChristianZaccaria sounds good.

/cc @sutaakar

@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ChristianZaccaria
Copy link
Contributor Author

Closing this PR as discussed in the comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants