RHOAIENG-11046 - Create GPU test for AMD #233
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jiripetrlik
requested review from
sutaakar and
ChughShilpa
and removed request for
varshaprasad96 and
Bobbins228
tests/odh/mnist_ray_test.go
Outdated
| } | ||
|
|
||
| func TestMnistCustomRayImageGpu(t *testing.T) { | ||
| mnistRay(t, 1) | ||
| mnistRay(t, 1, true) |
There was a problem hiding this comment.
This test TestMnistCustomRayImageGpu is for custom cuda-ray image which is torch compatible and it refer
quay.io/rhoai/ray:2.35.0-py39-cu121-torch24-sh20 image
Thus, amd bool should be false for this test.
| } | ||
|
|
||
| func mnistRay(t *testing.T, numGpus int) { | ||
| func mnistRay(t *testing.T, numGpus int, amd bool) { |
There was a problem hiding this comment.
It may be better to provide resource annotations and ray image as parameter instead of using conditions in test.
Personally I find it more readable, keeping the test code cleaner, without conditions.
jiripetrlik
force-pushed
the
RHOAIENG-11046
branch
from
c263e3c
to
d3cc78d
Compare
Add test for Ray on AMD GPU.
Description
How Has This Been Tested?
Merge criteria: