Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add automated test for HPO raytune-aoi-MR-gRPC demo example #234

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Add automated test for HPO raytune-aoi-MR-gRPC demo example #234

wants to merge 1 commit into from

Conversation

abhijeet-dhumal
Copy link
Contributor

@abhijeet-dhumal abhijeet-dhumal commented Sep 26, 2024 •
edited
Loading

Description

RHOAIENG-11559 - Add E2E test for HPO with RayTune Model Registry Demo - Source

How Has This Been Tested?

export NOTEBOOK_USER_NAME=<user-name> \
NOTEBOOK_USER_TOKEN=<user-auth-token> \
ODH_NAMESPACE=redhat-ods-applications \
NOTEBOOK_IMAGE=quay.io/modh/odh-generic-data-science-notebook@sha256:576c08ad9d4883836653af0659933e7ef97389385b920c7b236c6b1df86e7afa \
FMS_HF_TUNING_IMAGE=quay.io/modh/fms-hf-tuning@sha256:f8f732c340488734bf9023953d14bb2410991bd3ff2a519ad2ce07c531353797

go test -timeout 30m -v ./tests/odh -run  TestRaytuneOaiMrGrpcCpu

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Sep 26, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign fiona-waters for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

sutaakar
sutaakar reviewed Sep 26, 2024
View reviewed changes
tests/odh/raytune_oai_mr_grpc_test.go
test.Expect(err).ToNot(HaveOccurred())

// Start the Model Registry service with PostgreSQL as the backend database
cmd := exec.Command("kubectl", "apply", "-n", string(namespace.Name), "-k", fmt.Sprintf("%s/resources/model_registry_config_samples", workingDirectory))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to create the ModelRegistry CR programmatically?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it is possible, Let me check!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sutaakar sutaakar sutaakar left review comments

@astefanutti astefanutti Awaiting requested review from astefanutti

Assignees
No one assigned
Labels
do-not-merge/work-in-progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abhijeet-dhumal @sutaakar