Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sanity integration tests and Ray cluster test #66

Merged
merged 1 commit into from
Jul 25, 2023

Conversation

sutaakar
Copy link
Contributor

@sutaakar sutaakar commented Jul 24, 2023

Description

Implementing initial test coverage using integration tests based on Go.
Right now I cover just usage of Ray cluster, following PRs will cover also CodeFlare components.
First part of #63

How Has This Been Tested?

By running the new Go tests against configured OCP with ODH deployment (based on quickstart instructions).

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@sutaakar
Copy link
Contributor Author

sutaakar commented Jul 24, 2023

Depends on project-codeflare/codeflare-operator#194

@sutaakar
Copy link
Contributor Author

@winklerm FYI

@sutaakar sutaakar marked this pull request as ready for review July 25, 2023 10:40
tests/integration/ray_test.go Show resolved Hide resolved
tests/integration/sanity_test.go Outdated Show resolved Hide resolved
tests/integration/ray_test.go Outdated Show resolved Hide resolved
@astefanutti
Copy link
Contributor

/lgtm

@astefanutti astefanutti merged commit a8e4423 into opendatahub-io:main Jul 25, 2023
@sutaakar sutaakar deleted the new-tests branch July 25, 2023 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants