-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add additional step to pipeline to generate a metrics report #241
Open
MichaelClifford
wants to merge
3
commits into
opendatahub-io:main
Choose a base branch
from
MichaelClifford:metrics
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tumido
reviewed
Dec 18, 2024
MichaelClifford
force-pushed
the
metrics
branch
3 times, most recently
from
December 19, 2024 21:50
cad432f
to
8a6be72
Compare
@tumido updated the PR to use PVC's instead of interim output artifacts. |
MichaelClifford
force-pushed
the
metrics
branch
from
December 21, 2024 16:17
8a6be72
to
efe0ed0
Compare
tumido
reviewed
Jan 6, 2025
MichaelClifford
force-pushed
the
metrics
branch
from
January 6, 2025 17:25
efe0ed0
to
70fe60c
Compare
tumido
reviewed
Jan 7, 2025
leseb
reviewed
Jan 7, 2025
MichaelClifford
force-pushed
the
metrics
branch
from
January 8, 2025 00:36
1f4bd14
to
06ea8aa
Compare
tumido
reviewed
Jan 8, 2025
leseb
reviewed
Jan 8, 2025
MichaelClifford
force-pushed
the
metrics
branch
3 times, most recently
from
January 9, 2025 02:20
2508289
to
898b6f7
Compare
tumido
reviewed
Jan 13, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have one last suggestion, otherwise LGTM. 👍 🙌
MichaelClifford
force-pushed
the
metrics
branch
from
January 17, 2025 21:07
898b6f7
to
2082302
Compare
Signed-off-by: Michael Clifford <[email protected]>
Signed-off-by: Michael Clifford <[email protected]>
MichaelClifford
force-pushed
the
metrics
branch
from
January 17, 2025 21:30
2082302
to
6259904
Compare
Signed-off-by: Michael Clifford <[email protected]>
MichaelClifford
force-pushed
the
metrics
branch
from
January 17, 2025 21:31
6259904
to
9458ad4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new step to the end of the pipeline,
generate_metrics_report_op
. The purpose of this step is to create a number of kfpMertic
artifacts that can help users easily compare the performance between different runs using thecompare runs
feature of the Data Science Pipeline UI.