Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test KF 1.6 on OpenShift #101

Merged
merged 11 commits into from
Sep 19, 2022

Conversation

VaishnaviHire
Copy link
Member

@VaishnaviHire VaishnaviHire commented Aug 16, 2022

Which issue is resolved by this Pull Request:
Resolves #99

Description of your changes:

Testing Instructions:

  1. OCP version - 4.9
  2. Create kubeflow namespace
  3. Deploy manifest using steps given here -
    https://github.com/opendatahub-io/manifests/blob/5c33ee88a2c4b78cc8fe5ec1eced3233faa204db/openshift/README.md#install-kf-16-on-openshift

@openshift-ci openshift-ci bot requested review from LaVLaS and samuelvl August 16, 2022 19:36
@VaishnaviHire VaishnaviHire force-pushed the test_KF1.6 branch 3 times, most recently from 311330d to 82e6104 Compare August 18, 2022 19:23
@VaishnaviHire
Copy link
Member Author

This PR tests Kubeflow applications with Istio 1.14

cc: @LaVLaS

@LaVLaS
Copy link

LaVLaS commented Aug 23, 2022

Just tracking that I recieve the error below running kustomize build openshift/example/istio with kustomize v4.5.5 on a fresh OCP 4.10 cluster

2022/08/22 22:51:59 well-defined vars that were never replaced: VWA_NAMESPACE,bucket-base64,VWA_CLUSTER_DOMAIN,podDefaultsServiceName,CD_CLUSTER_DOMAIN,CD_REGISTRATION_FLOW,CD_USERID_HEADER,JWA_CLUSTER_DOMAIN,kfp-artifact-bucket-name,profile-name,secretAccessKey-bas64,CD_CONFIGMAP_NAME,JWA_PREFIX,JWA_UI,KATIB_CERT_NAME,kfp-default-pipeline-root,namespace,podDefaultsNamespace,JWA_USERID_PREFIX,KATIB_NAMESPACE,VWA_USERID_HEADER,kfp-app-version,podDefaultsCertName,kubelet-path,user,PROFILES_NAMESPACE,clusterDomain,kfp-namespace,KATIB_SERVICE_NAME,KATIB_UI_NAMESPACE,VWA_PREFIX,VWA_USERID_PREFIX,CD_NAMESPACE,CD_USERID_PREFIX,JWA_NAMESPACE,JWA_USERID_HEADER,accessKeyID-base64,endpoint-base64,kfp-app-name,podDefaultsDeploymentName
Error: considering field 'spec/template/spec/containers/*/args/2' of object DaemonSet.v1.apps/istio-cni-node.kube-system: visit traversal on path: [* args 2]: fieldName: *: wildcard is not supported in PathGetter

oc apply -k openshift/example/istio parsed the initial manifest without any issues
OC Client Version: 4.10.0-202206270836.p0.g45460a5.assembly.stream-45460a5

@VaishnaviHire
Copy link
Member Author

Just tracking that I recieve the error below running kustomize build openshift/example/istio with kustomize v4.5.5 on a fresh OCP 4.10 cluster

2022/08/22 22:51:59 well-defined vars that were never replaced: VWA_NAMESPACE,bucket-base64,VWA_CLUSTER_DOMAIN,podDefaultsServiceName,CD_CLUSTER_DOMAIN,CD_REGISTRATION_FLOW,CD_USERID_HEADER,JWA_CLUSTER_DOMAIN,kfp-artifact-bucket-name,profile-name,secretAccessKey-bas64,CD_CONFIGMAP_NAME,JWA_PREFIX,JWA_UI,KATIB_CERT_NAME,kfp-default-pipeline-root,namespace,podDefaultsNamespace,JWA_USERID_PREFIX,KATIB_NAMESPACE,VWA_USERID_HEADER,kfp-app-version,podDefaultsCertName,kubelet-path,user,PROFILES_NAMESPACE,clusterDomain,kfp-namespace,KATIB_SERVICE_NAME,KATIB_UI_NAMESPACE,VWA_PREFIX,VWA_USERID_PREFIX,CD_NAMESPACE,CD_USERID_PREFIX,JWA_NAMESPACE,JWA_USERID_HEADER,accessKeyID-base64,endpoint-base64,kfp-app-name,podDefaultsDeploymentName
Error: considering field 'spec/template/spec/containers/*/args/2' of object DaemonSet.v1.apps/istio-cni-node.kube-system: visit traversal on path: [* args 2]: fieldName: *: wildcard is not supported in PathGetter

oc apply -k openshift/example/istio parsed the initial manifest without any issues OC Client Version: 4.10.0-202206270836.p0.g45460a5.assembly.stream-45460a5

Did you get this error in 4.9 cluster as well ?

@LaVLaS
Copy link

LaVLaS commented Aug 31, 2022

/lgtm

@LaVLaS
Copy link

LaVLaS commented Aug 31, 2022

/approve

@openshift-ci openshift-ci bot removed the lgtm label Aug 31, 2022
@VaishnaviHire
Copy link
Member Author

@LaVLaS Requesting review for KF 1.6 docs changes - kubeflow/website@8b5f61a

@VaishnaviHire
Copy link
Member Author

For reference, servicemesh stack updates will be in a separate PR, once this is merged

@VaishnaviHire
Copy link
Member Author

Docs PR : kubeflow/website#3342

@LaVLaS
Copy link

LaVLaS commented Sep 1, 2022

Disregard any previous error the KF release only support kustomize v3 and I was using a kustomize v4 binary

kubeflow#2200 (comment)

fix dex configmap path (kubeflow#2179)

(cherry picked from commit 353254a)

Add kserve networkpolicy (kubeflow#2189)

* Create kserve

* Rename kserve to kserve.yaml

* Update kustomization.yaml

(cherry picked from commit 5e9fedb)

Sync kubeflow/pipelines manifests 1.8.2 (kubeflow#2223)

* Update kubeflow/pipelines manifests from 1.8.2

* update example, tests

(cherry picked from commit e794211)

Update kubeflow/kfp-tekton manifests from v1.2.1 (kubeflow#2222)

Signed-off-by: Yihong Wang <[email protected]>
(cherry picked from commit 5b1256f)

Update minio and metadata-envoy networkpolicy (kubeflow#2205)

* Update minio.yaml

* Add files via upload

* Update kustomization.yaml

(cherry picked from commit cbc18ec)

Test that each component can be applied in a K8s 1.22 cluster (kubeflow#2230)

* Add GH action for testing JWA manifests.

* Update permissions.

* Add GH actions for PodDefaults.

* Add GH actions for PodDefaults fix typo.

* Add GH actions for applying manifests in KinD for each component.

* Fix cert manager installation in all Actions.

* Address review comments for all GH actions.

(cherry picked from commit 76f3cf2)

common: Add Istio 1.14.1 manifests (kubeflow#2233)

* common: Add Istio 1.14.1 manifests

Signed-off-by: Dimitris Poulopoulos <[email protected]>

* testing: Update install Istio GH action script

Update GH actions to use Istio 1.14 for testing.

Signed-off-by: Dimitris Poulopoulos <[email protected]>
(cherry picked from commit 7a74ea2)

Sync kubeflow training operator manifests v1.5.0 rc.0 (kubeflow#2232)

* readme: Use new link for training-operator

Don't use the tf-operator but training-operator

Signed-off-by: Kimonas Sotirchos <[email protected]>

* hack: Update sync script for Training Operator

Signed-off-by: Kimonas Sotirchos <[email protected]>

* Update kubeflow/training-operator manifests from v1.5.0-rc.0

(cherry picked from commit 6fce75e)

Update kubeflow/katib manifests from v0.14.0-rc.0 (kubeflow#2234)

(cherry picked from commit dcbd493)

chore: Remove outdated Istio manifests (kubeflow#2163)

(cherry picked from commit bec0e26)

Update README with Istio 1.4.1 (kubeflow#2235)

Signed-off-by: Anna Jung (VMware) <[email protected]>
(cherry picked from commit f8318a8)

Remove istio 1.11 (kubeflow#2236)

Signed-off-by: Anna Jung (VMware) <[email protected]>
(cherry picked from commit 5c600ad)

Update Knative 1.4 (kubeflow#2231)

* knative: Update README for v1.4.0

Signed-off-by: Kimonas Sotirchos <[email protected]>

* knative: wget latest manifests

Signed-off-by: Kimonas Sotirchos <[email protected]>

* knative: Remove all comments

Signed-off-by: Kimonas Sotirchos <[email protected]>

* knative: Remove knative-ingress-gateway

Had to manually remove a `{}` object at the end, introduced by the yq
command.

Signed-off-by: Kimonas Sotirchos <[email protected]>

* knative: Update README for removing {}

Signed-off-by: Kimonas Sotirchos <[email protected]>

* knative: Set metadata.name in post-install-job

Signed-off-by: Kimonas Sotirchos <[email protected]>

* knative-eventing: Update with v1.4.0 manifests

Signed-off-by: Kimonas Sotirchos <[email protected]>

* knative-eventing: Remove comments

Signed-off-by: Kimonas Sotirchos <[email protected]>

* knative-eventing: Remove anchors

Signed-off-by: Kimonas Sotirchos <[email protected]>

* knative-eventing: Install only core

Signed-off-by: Kimonas Sotirchos <[email protected]>
(cherry picked from commit c602b5c)

Move all tests under tests dir (kubeflow#2237)

* tests: Move everything under tests

Signed-off-by: Kimonas Sotirchos <[email protected]>

* test: Move everything under test

Signed-off-by: Kimonas Sotirchos <[email protected]>
(cherry picked from commit 666bb8c)

remove kfserving component (kubeflow#2239)

(cherry picked from commit e05f2c6)

Change images of KinD configuration files to be compatible with v0.14.0 (kubeflow#2238)

* Change images of KinD configuration files to be compatible with v0.14.0

* Move everything under the tests folder.

* Update actions with the new name of the config file.

(cherry picked from commit 7221470)

Sync kserve manifests for v0.8.0 (kubeflow#2240)

* Update kserve manifests from v0.8.0

Update kserve/kserve manifests from 8079f375cbcedc4d45a1b4aade2e2308ea6f9ae8

Update kserve/models-web-app manifests from v0.8.0

* add auto script for kserve and kserve models webapp manifests

* update readme and kustomization

* add rretry in kserve install for webhook

* ignore error while installing

* move cmds to script to allow local testing and remove sleep

* move crd wait outside set +e

(cherry picked from commit c3db49b)

Update kubeflow/kubeflow manifests from v1.6.0-rc.0 (kubeflow#2242)

(cherry picked from commit 6b60781)

Update Dex for K8s 1.22 (kubeflow#2243)

* dex: Update for K8s 1.22

Needed to update the deprecated APIs from v1beta1 to v1 for:
* CRD for AuthCode
* ClusterRole
* ClusterRoleBinding

Signed-off-by: Kimonas Sotirchos <[email protected]>

* gh-actions: CI action for Dex

Create a GH Action that tests if:
1. Dex manifests can be applied in a KinD K8s 1.22 cluster
2. All pods can become ready

Signed-off-by: Kimonas Sotirchos <[email protected]>

* dex: Update image to 2.31.2

Signed-off-by: Kimonas Sotirchos <[email protected]>
(cherry picked from commit dca1071)

Update kubeflow/pipelines manifests from 2.0.0-alpha.3 (kubeflow#2250)

* Update kubeflow/pipelines manifests from 2.0.0-alpha.3

Signed-off-by: Anna Jung (VMware) <[email protected]>

* Move pipeline manifest test commands to a separate script

Signed-off-by: Anna Jung (VMware) <[email protected]>

* Change pipeline installation command back to apply crd only

Signed-off-by: Anna Jung (VMware) <[email protected]>
(cherry picked from commit d701e97)

istio: Remove Istio 1.14 overlays (kubeflow#2252)

Remove overlays in 'kubeflow-istio-resources' for version 1.14.

Signed-off-by: Dimitris Poulopoulos <[email protected]>
(cherry picked from commit 707f8f6)

knative: Updrade Knative to version 1.2 (kubeflow#2251)

* Update the README file
* Fetch the manifests for Knative serving 1.2.5
* Fetch the manifests for Knative eventing 1.2.4
* Remove comments, anchors and aliases

Signed-off-by: Dimitris Poulopoulos <[email protected]>
(cherry picked from commit 0660ee0)

readme: Update component versions (kubeflow#2253)

Signed-off-by: Kimonas Sotirchos <[email protected]>

Fix typo in the networkpolicies (kubeflow#2254)

Use KServe component in tests instead of KFServing (kubeflow#2164)

* Use KServe component in tests instead of KFServing as it is updated upstream https://github.com/kubeflow/pipelines/blob/master/samples/contrib/kubeflow-e2e-mnist/kubeflow-e2e-mnist.ipynb

* Add permalink

Extend Katib GH action to also create an experiment and assert it succeeds (kubeflow#2249)

* Extend Katib GH action to also create an experiment and assert it succeeds. (kubeflow#2248)

* Rearrange folders for KF objects in tests.

Sync kserve web app manifests v0.8.1 (kubeflow#2256)

* hack: Destinct sync script for the web app

Signed-off-by: Kimonas Sotirchos <[email protected]>

* Update kserve web app manifests from v0.8.1

* hack: Update the kserve sync script

Signed-off-by: Kimonas Sotirchos <[email protected]>

* e2e: Increase the timeout to 10mins

We've seen that quite frequently the test times out either because:
1. Pulling images can be slower depending on the connection
2. There might be some delays with the components to complete

We've noticed this for the Training Operator worker pod.

Signed-off-by: Kimonas Sotirchos <[email protected]>

* e2e: Change the cleanup script for kserve.io

The clean up script would previously try to delete kubeflow.org
inference services.

Signed-off-by: Kimonas Sotirchos <[email protected]>

Update kubeflow/kubeflow manifests from v1.6.0-rc.1 (kubeflow#2260)
@VaishnaviHire
Copy link
Member Author

Branch updated with latest rc - v1.6.0-rc.3

 oc get po -n kubeflow
NAME                                               READY   STATUS    RESTARTS       AGE
admission-webhook-deployment-b878cdc4c-w75vk       1/1     Running   0              60m
cache-deployer-deployment-54d9945778-9d8jk         1/1     Running   0              174m
cache-server-577679d7b9-tq2ts                      1/1     Running   0              174m
centraldashboard-7855dc7958-97rgp                  1/1     Running   0              60m
csi-attacher-s3-0                                  1/1     Running   0              174m
csi-provisioner-s3-0                               1/1     Running   0              174m
jupyter-web-app-deployment-54f9c4f8b6-ss4vt        1/1     Running   0              60m
katib-controller-6848d4dd9f-lt8q2                  1/1     Running   0              174m
katib-db-manager-665954948-xvdbl                   1/1     Running   0              174m
katib-mysql-5bf95ddfcc-9x7br                       1/1     Running   0              174m
katib-ui-56ccff658f-n9mv2                          1/1     Running   0              174m
kfp-csi-s3-jv4tz                                   2/2     Running   0              174m
kfp-csi-s3-vxwpq                                   2/2     Running   0              174m
kfp-csi-s3-zsmms                                   2/2     Running   0              174m
kserve-controller-manager-0                        2/2     Running   0              174m
kserve-models-web-app-544c6b55bb-vh4mc             1/1     Running   0              174m
metadata-envoy-deployment-7b847ff6c5-mvfmv         1/1     Running   0              174m
metadata-grpc-deployment-f8d68f687-fhrgx           1/1     Running   3 (172m ago)   174m
metadata-writer-6b4945489-fzpw7                    1/1     Running   0              174m
minio-5b65df66c9-zfd9k                             1/1     Running   0              174m
ml-pipeline-64bc96bdbd-lzkhj                       1/1     Running   2 (171m ago)   174m
ml-pipeline-persistenceagent-776998878b-g6ftc      1/1     Running   0              174m
ml-pipeline-scheduledworkflow-55fb486f8f-ssm97     1/1     Running   0              174m
ml-pipeline-ui-544c99bc9-6mv4l                     1/1     Running   0              174m
ml-pipeline-viewer-crd-68bdd5f6f5-pc6nq            1/1     Running   0              174m
ml-pipeline-visualizationserver-66979c8f66-jrvcc   1/1     Running   0              174m
mysql-f7b9b7dd4-gbwlz                              1/1     Running   0              174m
notebook-controller-deployment-54f5c68b76-4b6fw    1/1     Running   0              60m
profiles-deployment-567d85d86d-kmzzn               2/2     Running   0              60m
training-operator-6c9f6fd894-rmq58                 1/1     Running   0              36s
volumes-web-app-deployment-5c656c7f-p6bjn          1/1     Running   0              60m


oc get po -n istio-system
NAME                                     READY   STATUS    RESTARTS   AGE
cluster-local-gateway-55ff4696f4-52qvg   1/1     Running   0          174m
istio-ingressgateway-8584f6cbf6-wcjpc    1/1     Running   0          4m2s
istiod-95c7f6cc7-fvfc2                   1/1     Running   0          23m

Signed-off-by: Anna Jung (VMware) <[email protected]>

Signed-off-by: Anna Jung (VMware) <[email protected]>
(cherry picked from commit 35eda37)

Update kubeflow/training-operator manifests from v1.5.0 (kubeflow#2272)

(cherry picked from commit c89471f)

Update kubeflow/kubeflow manifests from v1.6.0-rc.3 (kubeflow#2279)

Signed-off-by: Anna Jung (VMware) <[email protected]>

Signed-off-by: Anna Jung (VMware) <[email protected]>
(cherry picked from commit 5ee3302)
Copy link

@LaVLaS LaVLaS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Sep 6, 2022
@openshift-ci openshift-ci bot removed the lgtm label Sep 6, 2022
@openshift-ci
Copy link

openshift-ci bot commented Sep 6, 2022

New changes are detected. LGTM label has been removed.

@LaVLaS
Copy link

LaVLaS commented Sep 7, 2022

/approve

@openshift-ci
Copy link

openshift-ci bot commented Sep 7, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: LaVLaS

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nachogarciam
Copy link

Hi team!, I was wondering if there is a way to install kf 1.6 but multi user

@LaVLaS LaVLaS merged commit f5c82a4 into opendatahub-io:v1.6-branch-openshift Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants