Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade odh-elyra 3.16.7 for run_url update #578

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

harshad16
Copy link
Member

@harshad16 harshad16 commented Jun 21, 2024

Upgrade odh-elyra 3.16.7 for run_url update
https://github.com/opendatahub-io/elyra/releases/tag/3.16.7

Description

Set the run_url with experiment info included

The run_url is set in the format of: {experiment_id}/runs/{run_id}
Example:

https://rhods-dashboard-redhat-ods-applications.apps.datahub.redhat.com/experiments/experiment/024e260b-75e9-407e-9e8d-3974320c06dc/runs/b6c920a2-a3de-452c-bf58-88d46f3da65b

Related-to: https://issues.redhat.com/browse/RHOAIENG-8398

How Has This Been Tested?

This PR needs to be run with the compliment of the Dashboard Image:
Use the following image: quay.io/opendatahub/odh-dashboard:main-a8d2118

  1. Set up a DS project
  2. Create a Data connection
  3. Create Pipeline configuration
  4. Use data-science notebook image create by this PR.
  5. Execute a Pipeline
    and check the RUN Details pointing to right pipeline run executed
    Screenshot from 2024-06-21 05-10-17

Expected:
URL should be of the form: https://rhods-dashboard-redhat-ods-applications.apps.datahub.redhat.com/experiments/experiment/024e260b-75e9-407e-9e8d-3974320c06dc/runs/b6c920a2-a3de-452c-bf58-88d46f3da65b

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@openshift-ci openshift-ci bot requested review from atheo89 and caponetto June 21, 2024 09:11
@atheo89
Copy link
Member

atheo89 commented Jun 21, 2024

/lgtm

I could reproduce this
..../experiments/experiment/ae910d56-bdd9-482b-b6a1-5c1f1ae25402

Copy link
Member

@jiridanek jiridanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if it works, then it works
/lgtm

habana/1.13.0/ubi8-python-3.8/Pipfile Show resolved Hide resolved
Copy link
Contributor

openshift-ci bot commented Jun 21, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jiridanek
Once this PR has been reviewed and has the lgtm label, please ask for approval from atheo89. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Jun 21, 2024

@harshad16: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/images e3b94ac link true /test images
ci/prow/notebooks-e2e-tests e3b94ac link true /test notebooks-e2e-tests
ci/prow/habana-notebooks-e2e-tests e3b94ac link true /test habana-notebooks-e2e-tests
ci/prow/notebooks-ubi8-e2e-tests e3b94ac link true /test notebooks-ubi8-e2e-tests
ci/prow/codeserver-notebook-e2e-tests e3b94ac link true /test codeserver-notebook-e2e-tests
ci/prow/rstudio-notebook-e2e-tests e3b94ac link true /test rstudio-notebook-e2e-tests
ci/prow/intel-notebooks-e2e-tests e3b94ac link true /test intel-notebooks-e2e-tests
ci/prow/notebooks-ubi9-e2e-tests e3b94ac link true /test notebooks-ubi9-e2e-tests
ci/prow/runtimes-ubi9-e2e-tests e3b94ac link true /test runtimes-ubi9-e2e-tests
ci/prow/anaconda-ubi8-e2e-tests e3b94ac link true /test anaconda-ubi8-e2e-tests
ci/prow/runtimes-ubi8-e2e-tests e3b94ac link true /test runtimes-ubi8-e2e-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@harshad16
Copy link
Member Author

Thank you for the review.
i will move forward with merging.

@harshad16 harshad16 merged commit 5b5aacb into opendatahub-io:main Jun 21, 2024
40 of 51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants