-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade odh-elyra 3.16.7 for run_url update #578
Conversation
Signed-off-by: Harshad Reddy Nalla <[email protected]>
/lgtm I could reproduce this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if it works, then it works
/lgtm
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jiridanek The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@harshad16: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Thank you for the review. |
Upgrade odh-elyra 3.16.7 for run_url update
https://github.com/opendatahub-io/elyra/releases/tag/3.16.7
Description
Set the run_url with experiment info included
The run_url is set in the format of:
{experiment_id}/runs/{run_id}
Example:
Related-to: https://issues.redhat.com/browse/RHOAIENG-8398
How Has This Been Tested?
This PR needs to be run with the compliment of the Dashboard Image:
Use the following image:
quay.io/opendatahub/odh-dashboard:main-a8d2118
and check the RUN Details pointing to right pipeline run executed
Expected:
URL should be of the form:
https://rhods-dashboard-redhat-ods-applications.apps.datahub.redhat.com/experiments/experiment/024e260b-75e9-407e-9e8d-3974320c06dc/runs/b6c920a2-a3de-452c-bf58-88d46f3da65b
Merge criteria: