-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RHOAIENG-17306, RHOAIENG-17307, RHOAIENG-17308: feat(workbenches): support IPv6 environments in codeserver, jupyterlab and rstudio #827
Open
chaturvedi-kna
wants to merge
3
commits into
opendatahub-io:main
Choose a base branch
from
chaturvedi-kna:clean-fix-ipv6-issue
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 0 additions & 3 deletions
3
codeserver/ubi9-python-3.11/nginx/root/opt/app-root/nginxconf.sed
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -46,6 +46,30 @@ def _support_arg(arg): | |
ret = subprocess.check_output([get_rstudio_executable('rserver'), '--help']) | ||
return ret.decode().find(arg) != -1 | ||
|
||
def detect_env(): | ||
import socket | ||
supports_ipv4 = supports_ipv6 = False | ||
try: | ||
with socket.socket(socket.AF_INET, socket.SOCK_STREAM) as s: | ||
s.bind(('127.0.0.1', 0)) | ||
supports_ipv4 = True | ||
except OSError: | ||
pass | ||
try: | ||
with socket.socket(socket.AF_INET6, socket.SOCK_STREAM) as s: | ||
s.bind(('::1', 0)) | ||
supports_ipv6 = True | ||
except OSError: | ||
pass | ||
if supports_ipv4 and supports_ipv6: | ||
return '::' # Dual-stack | ||
elif supports_ipv6: | ||
return '::' | ||
elif supports_ipv4: | ||
return '0.0.0.0' | ||
else: | ||
raise EnvironmentError('No IPv4 or IPv6 support detected.') | ||
|
||
def _get_cmd(port): | ||
ntf = tempfile.NamedTemporaryFile() | ||
|
||
|
@@ -60,7 +84,7 @@ def _get_cmd(port): | |
'--server-working-dir=' + os.getenv('HOME'), | ||
'--auth-none=1', | ||
'--www-frame-origin=same', | ||
#'--www-address=0.0.0.0', | ||
'--www-address='+ detect_env(), | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Right, the default value won't cut it |
||
'--www-port=' + str(port), | ||
'--www-verify-user-agent=0', | ||
'--rsession-which-r=' + get_rstudio_executable('R'), | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm inclined to replace all this with
return '::'
, because that should work just everywhere; We have ubi9 images that do support ipv6; and jupyterlab/etc. all usesocket.AF_INET6
in effect. But your version feels somewhat more cautious and safer.