Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add a low profile overlay #2841

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

andrewballantyne
Copy link
Member

@andrewballantyne andrewballantyne commented May 22, 2024

Add a standard low profile mode for the Dashboard. This way we can be run with minimal items

DSC Status:

spec:
  dashboard:
      devFlags:
        manifests:
          - contextDir: manifests
            sourcePath: overlays/lowProfile
            uri: >-
              https://github.com/andrewballantyne/odh-dashboard/tarball/lowProfile
    managementState: Managed

Testing...

  • Currently the network requests are awfully slow, takes a few seconds to get the loaded state of anything. Likely will end up queuing hard behind the requests if polling ie excessive.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress This PR is in WIP state label May 22, 2024
Copy link
Contributor

openshift-ci bot commented May 22, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from andrewballantyne. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented May 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.42%. Comparing base (cd93b29) to head (8bdf0cf).
Report is 396 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2841      +/-   ##
==========================================
+ Coverage   77.40%   77.42%   +0.02%     
==========================================
  Files        1101     1101              
  Lines       23168    23192      +24     
  Branches     5841     5848       +7     
==========================================
+ Hits        17933    17957      +24     
  Misses       5235     5235              

see 8 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd93b29...8bdf0cf. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress This PR is in WIP state
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant