-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix some trusty issues #3371
Fix some trusty issues #3371
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3371 +/- ##
==========================================
+ Coverage 85.91% 85.95% +0.03%
==========================================
Files 1338 1339 +1
Lines 30283 30342 +59
Branches 8356 8384 +28
==========================================
+ Hits 26018 26079 +61
+ Misses 4265 4263 -2
... and 32 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
a373459
to
6ecd409
Compare
/retest |
1 similar comment
/retest |
I am going to put a lgtm bc the code looks good. I tried to test it but i could not find the test model they were using and kept getting this back when trying to create the metric from the cli {"title":"Constraint Violation","status":400,"violations":[{"field":"createRequest.request.mnist.onnx","message":"No metadata found for model=mnist.onnx. This can happen if TrustyAI has not yet logged any inferences from this model."},{"field":"createRequest.request","message":"The supplied metric request details are not valid."}]}% /lgtm |
6ecd409
to
a7fb768
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Gkrumbach07 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
https://issues.redhat.com/browse/RHOAIENG-15008
Description
Fixes an incorrect type of required
requestName
and defaults to a generated one if it's missing.How Has This Been Tested?
Test Impact
None, bad type -- everything should be working as intended.
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main