Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some trusty issues #3371

Merged

Conversation

andrewballantyne
Copy link
Member

@andrewballantyne andrewballantyne commented Oct 23, 2024

https://issues.redhat.com/browse/RHOAIENG-15008

Description

Fixes an incorrect type of required requestName and defaults to a generated one if it's missing.

How Has This Been Tested?

  • Create a Trusty Service against a DB (using the Mariadb steps)
  • Create a Trusty metric via the CLI with the specific fail points (see RHOAIENG-15008 ticket for details)
  • UI now renders it with a generated name

Test Impact

None, bad type -- everything should be working as intended.

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.95%. Comparing base (7068314) to head (a7fb768).
Report is 27 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3371      +/-   ##
==========================================
+ Coverage   85.91%   85.95%   +0.03%     
==========================================
  Files        1338     1339       +1     
  Lines       30283    30342      +59     
  Branches     8356     8384      +28     
==========================================
+ Hits        26018    26079      +61     
+ Misses       4265     4263       -2     
Files with missing lines Coverage Δ
frontend/src/api/trustyai/rawTypes.ts 100.00% <ø> (ø)
frontend/src/concepts/trustyai/utils.ts 63.88% <100.00%> (+1.03%) ⬆️

... and 32 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3db54bd...a7fb768. Read the comment docs.

@andrewballantyne
Copy link
Member Author

/retest

1 similar comment
@andrewballantyne
Copy link
Member Author

/retest

@Gkrumbach07
Copy link
Member

I am going to put a lgtm bc the code looks good. I tried to test it but i could not find the test model they were using and kept getting this back when trying to create the metric from the cli

{"title":"Constraint Violation","status":400,"violations":[{"field":"createRequest.request.mnist.onnx","message":"No metadata found for model=mnist.onnx. This can happen if TrustyAI has not yet logged any inferences from this model."},{"field":"createRequest.request","message":"The supplied metric request details are not valid."}]}%       

/lgtm

Copy link
Member

@Gkrumbach07 Gkrumbach07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

tested before and after change and error is gone

before:
Screenshot 2024-11-06 at 1 11 06 PM

after:
Screenshot 2024-11-06 at 1 11 24 PM

@openshift-ci openshift-ci bot added the lgtm label Nov 6, 2024
Copy link
Contributor

openshift-ci bot commented Nov 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Gkrumbach07

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Nov 6, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 8305246 into opendatahub-io:main Nov 6, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants