Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete connection ref from notebooks when connection is deleted #3428

Conversation

jeff-phillips-18
Copy link
Contributor

Closes RHOAIENG-14208

Description

When removing a connection, delete the env var from the env var list of any connected notebooks

How Has This Been Tested?

Delete a connection that has connected notebooks
Go to the workbenches tab and edit the notebooks that were connected.
Verify the connection is no longer listed in the Connections section

Request review criteria:

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

@christianvogt
Copy link
Contributor

/lgtm
/approve

Copy link
Contributor

openshift-ci bot commented Nov 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Nov 4, 2024
Copy link

codecov bot commented Nov 4, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 85.94%. Comparing base (217787a) to head (b90f76e).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...eens/detail/connections/ConnectionsDeleteModal.tsx 80.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3428   +/-   ##
=======================================
  Coverage   85.93%   85.94%           
=======================================
  Files        1339     1339           
  Lines       30308    30311    +3     
  Branches     8367     8369    +2     
=======================================
+ Hits        26046    26050    +4     
+ Misses       4262     4261    -1     
Files with missing lines Coverage Δ
.../screens/detail/connections/ConnectedResources.tsx 91.66% <100.00%> (ø)
...ts/screens/detail/connections/ConnectionsTable.tsx 100.00% <ø> (ø)
...eens/detail/connections/ConnectionsDeleteModal.tsx 82.97% <80.00%> (-1.12%) ⬇️

... and 7 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 217787a...b90f76e. Read the comment docs.

@openshift-merge-bot openshift-merge-bot bot merged commit 3c44cac into opendatahub-io:main Nov 4, 2024
6 checks passed
@jeff-phillips-18 jeff-phillips-18 deleted the clean-notebook-secret branch November 5, 2024 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants