Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popover fixes/additions #3433

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ashley-o0o
Copy link
Contributor

@ashley-o0o ashley-o0o commented Nov 5, 2024

Closes: RHOAIENG-13049

Description

Tooltip to popover updates
Updates from tooltip to popover made in various areas. Also added popovers to a few areas

How Has This Been Tested?

Tested locally on these pages:

  • Model registry settings - default group tooltip changed to popover
  • Model list page - owner tooltip changed to popover
  • Model details and archived model details - owner popover added
  • Version list and archived version list - author popover added

Test Impact

No new tests added

Screenshots

Tooltip - popover
Before:
Screenshot 2024-11-05 at 11 21 13 AM
After:
Screenshot 2024-11-05 at 11 20 50 AM

Before:
Screenshot 2024-11-05 at 11 26 31 AM
After:
Screenshot 2024-11-05 at 11 26 44 AM

Popover additions:
Screenshot 2024-11-05 at 11 22 20 AM
Screenshot 2024-11-05 at 11 25 28 AM

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@ashley-o0o ashley-o0o force-pushed the 13049/tooltip-to-popover-updates branch 2 times, most recently from 7f9647b to 924ad09 Compare November 5, 2024 18:59
Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.66%. Comparing base (a4ba326) to head (422fc87).
Report is 62 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3433      +/-   ##
==========================================
- Coverage   85.87%   85.66%   -0.22%     
==========================================
  Files        1338     1347       +9     
  Lines       30127    30680     +553     
  Branches     8274     8550     +276     
==========================================
+ Hits        25871    26281     +410     
- Misses       4256     4399     +143     
Files with missing lines Coverage Δ
...d/src/components/DashboardDescriptionListGroup.tsx 100.00% <100.00%> (ø)
...pts/roleBinding/RoleBindingPermissionsTableRow.tsx 90.16% <100.00%> (ø)
...ns/ModelVersionDetails/ModelVersionDetailsView.tsx 95.23% <ø> (+0.23%) ⬆️
...egistry/screens/ModelVersions/ModelDetailsView.tsx 80.00% <ø> (ø)
...screens/ModelVersions/ModelVersionsTableColumns.ts 100.00% <ø> (ø)
...s/RegisteredModels/RegisteredModelsTableColumns.ts 100.00% <ø> (ø)

... and 125 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4ba326...422fc87. Read the comment docs.

@jenny-s51 jenny-s51 self-requested a review November 6, 2024 19:26
Copy link
Contributor

@jenny-s51 jenny-s51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested all tooltip/popover instances noted in ticket and PR, changes look and work as expected.

Copy link
Contributor

openshift-ci bot commented Nov 6, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jenny-s51
Once this PR has been reviewed and has the lgtm label, please assign manosnoam for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

@christianvogt christianvogt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The screen shots show extra padding around the button. Try using DashboardPopupIconButton

@ashley-o0o ashley-o0o force-pushed the 13049/tooltip-to-popover-updates branch from 924ad09 to 8c4477b Compare November 7, 2024 18:55
@openshift-ci openshift-ci bot removed the lgtm label Nov 7, 2024
Copy link
Contributor

openshift-ci bot commented Nov 7, 2024

New changes are detected. LGTM label has been removed.

Copy link
Contributor

@jenny-s51 jenny-s51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updates to padding look great! Just one comment, otherwise LGTM 🚀

frontend/src/components/DashboardDescriptionListGroup.tsx Outdated Show resolved Hide resolved
@ashley-o0o ashley-o0o force-pushed the 13049/tooltip-to-popover-updates branch from 8c4477b to 422fc87 Compare November 7, 2024 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants