-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Popover fixes/additions #3433
base: main
Are you sure you want to change the base?
Popover fixes/additions #3433
Conversation
7f9647b
to
924ad09
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3433 +/- ##
==========================================
- Coverage 85.87% 85.66% -0.22%
==========================================
Files 1338 1347 +9
Lines 30127 30680 +553
Branches 8274 8550 +276
==========================================
+ Hits 25871 26281 +410
- Misses 4256 4399 +143
... and 125 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tested all tooltip/popover instances noted in ticket and PR, changes look and work as expected.
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jenny-s51 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The screen shots show extra padding around the button. Try using DashboardPopupIconButton
frontend/src/concepts/roleBinding/RoleBindingPermissionsTableRow.tsx
Outdated
Show resolved
Hide resolved
924ad09
to
8c4477b
Compare
New changes are detected. LGTM label has been removed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updates to padding look great! Just one comment, otherwise LGTM 🚀
8c4477b
to
422fc87
Compare
Closes: RHOAIENG-13049
Description
Tooltip to popover updates Updates from tooltip to popover made in various areas. Also added popovers to a few areas
How Has This Been Tested?
Tested locally on these pages:
Test Impact
No new tests added
Screenshots
Tooltip - popover
Before:
After:
Before:
After:
Popover additions:
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main