Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add helper text for default value sensitive information #3450

Merged

Conversation

christianvogt
Copy link
Contributor

@christianvogt christianvogt commented Nov 7, 2024

Description

Add helper text to default values to guide the user to not store sensitive information in default values.

image

How Has This Been Tested?

  • enable the connection types feature flag
  • create a connection type
  • add a field
  • observe the helper text below the default value

Test Impact

N/A

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

cc @simrandhaliw

@christianvogt christianvogt requested review from jeff-phillips-18 and emilys314 and removed request for alexcreasy and ppadti November 7, 2024 16:03
@simrandhaliw
Copy link

LGTM!

Copy link
Member

@andrewballantyne andrewballantyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm -- didn't run it, I have faith in a text addition 🙂

Copy link
Contributor

openshift-ci bot commented Nov 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewballantyne

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.65%. Comparing base (85e63ce) to head (e5ffa7c).
Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3450      +/-   ##
==========================================
+ Coverage   85.60%   85.65%   +0.05%     
==========================================
  Files        1347     1347              
  Lines       30642    30642              
  Branches     8521     8521              
==========================================
+ Hits        26231    26247      +16     
+ Misses       4411     4395      -16     
Files with missing lines Coverage Δ
...connectionTypes/manage/DataFieldPropertiesForm.tsx 80.00% <ø> (ø)

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85e63ce...e5ffa7c. Read the comment docs.

@openshift-merge-bot openshift-merge-bot bot merged commit 5ec3d22 into opendatahub-io:main Nov 7, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants