Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add env var to field details popover #3454

Merged

Conversation

christianvogt
Copy link
Contributor

Description

As part of the UX review we identified a missing update to the field details popover.
Added environment variable details to popover:

image
image

cc @simrandhaliw

How Has This Been Tested?

  • enable connection types feature flag
  • go to Settings -> Connection types
  • preview the s3 connection type
  • click the ? for a field
  • observe the popover details includes env var

Test Impact

N/A

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@simrandhaliw
Copy link

Lgtm!

Copy link
Contributor

openshift-ci bot commented Nov 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@emilys314
Copy link
Contributor

I just tested this out locally and it's working all good
image

/lgtm

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 85.66%. Comparing base (91584ea) to head (560abcf).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...epts/connectionTypes/fields/DataFormFieldGroup.tsx 50.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3454      +/-   ##
==========================================
- Coverage   85.66%   85.66%   -0.01%     
==========================================
  Files        1347     1347              
  Lines       30668    30678      +10     
  Branches     8537     8548      +11     
==========================================
+ Hits        26273    26281       +8     
- Misses       4395     4397       +2     
Files with missing lines Coverage Δ
...epts/connectionTypes/fields/DataFormFieldGroup.tsx 85.71% <50.00%> (ø)

... and 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91584ea...560abcf. Read the comment docs.

@openshift-merge-bot openshift-merge-bot bot merged commit 2350d91 into opendatahub-io:main Nov 7, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants