Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: modify behaviours for the enable button for NIM. #3558

Merge branch 'main' into NVPE-37-fix-the-enable-button-loading-issue

d1e042e
Select commit
Loading
Failed to load commit list.
Merged

feat: modify behaviours for the enable button for NIM. #3558

Merge branch 'main' into NVPE-37-fix-the-enable-button-loading-issue
d1e042e
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 13, 2025 in 0s

85.75% (-0.08%) compared to 3ea00fd

View this Pull Request on Codecov

85.75% (-0.08%) compared to 3ea00fd

Details

Codecov Report

Attention: Patch coverage is 18.75000% with 52 lines in your changes missing coverage. Please review.

Project coverage is 85.75%. Comparing base (3ea00fd) to head (d1e042e).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
frontend/src/utilities/useEnableApplication.tsx 5.26% 36 Missing ⚠️
frontend/src/components/OdhAppCard.tsx 0.00% 5 Missing ⚠️
...ntend/src/pages/exploreApplication/EnableModal.tsx 37.50% 5 Missing ⚠️
...d/src/pages/exploreApplication/GetStartedPanel.tsx 28.57% 5 Missing ⚠️
...nd/src/utilities/useWatchIntegrationComponents.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3558      +/-   ##
==========================================
- Coverage   85.82%   85.75%   -0.08%     
==========================================
  Files        1419     1419              
  Lines       32644    32678      +34     
  Branches     9167     9192      +25     
==========================================
+ Hits        28018    28022       +4     
- Misses       4626     4656      +30     
Files with missing lines Coverage Δ
...pages/exploreApplication/useIntegratedAppStatus.ts 88.88% <100.00%> (+1.38%) ⬆️
frontend/src/types.ts 100.00% <100.00%> (ø)
...nd/src/utilities/useWatchIntegrationComponents.tsx 37.73% <0.00%> (ø)
frontend/src/components/OdhAppCard.tsx 61.90% <0.00%> (-2.03%) ⬇️
...ntend/src/pages/exploreApplication/EnableModal.tsx 33.92% <37.50%> (+1.85%) ⬆️
...d/src/pages/exploreApplication/GetStartedPanel.tsx 62.06% <28.57%> (-2.22%) ⬇️
frontend/src/utilities/useEnableApplication.tsx 24.34% <5.26%> (-3.92%) ⬇️

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ea00fd...d1e042e. Read the comment docs.