Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit the ability to change the group configs #3585

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

andrewballantyne
Copy link
Member

https://issues.redhat.com/browse/RHOAIENG-15160

Description

Prevent group changes in the OdhDashboardConfig so all changes are properly in the Auth resource created by the Platform. See opendatahub-io/opendatahub-operator#1452 for those changes.

There is a UI change to support not writing to this resource anymore, see #3577.

When saving in OdhDashboardConfig, you should see an error like this:
image
It has a minor set of wording to point them to another resource.

How Has This Been Tested?

Apply the change to a cluster -- it'll mutate the CRD and the CR will no longer be modifiable.

Test Impact

N/A

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@andrewballantyne
Copy link
Member Author

/hold

We should wait on merging this until we have a good understanding of everything merging into ODH / RHOAI. This will block development flows around modifying the group configs.

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.18%. Comparing base (1896f34) to head (8508164).
Report is 6 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3585      +/-   ##
==========================================
- Coverage   85.19%   85.18%   -0.01%     
==========================================
  Files        1382     1382              
  Lines       31572    31572              
  Branches     8824     8824              
==========================================
- Hits        26897    26895       -2     
- Misses       4675     4677       +2     

see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1896f34...8508164. Read the comment docs.

Copy link
Member

@Gkrumbach07 Gkrumbach07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

image

Copy link
Contributor

openshift-ci bot commented Dec 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Gkrumbach07

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved do-not-merge/hold This PR is hold for some reason lgtm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants