-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Limit the ability to change the group configs #3585
base: main
Are you sure you want to change the base?
Limit the ability to change the group configs #3585
Conversation
/hold We should wait on merging this until we have a good understanding of everything merging into ODH / RHOAI. This will block development flows around modifying the group configs. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3585 +/- ##
==========================================
- Coverage 85.19% 85.18% -0.01%
==========================================
Files 1382 1382
Lines 31572 31572
Branches 8824 8824
==========================================
- Hits 26897 26895 -2
- Misses 4675 4677 +2 see 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Gkrumbach07 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
https://issues.redhat.com/browse/RHOAIENG-15160
Description
Prevent group changes in the OdhDashboardConfig so all changes are properly in the Auth resource created by the Platform. See opendatahub-io/opendatahub-operator#1452 for those changes.
There is a UI change to support not writing to this resource anymore, see #3577.
When saving in OdhDashboardConfig, you should see an error like this:
It has a minor set of wording to point them to another resource.
How Has This Been Tested?
Apply the change to a cluster -- it'll mutate the CRD and the CR will no longer be modifiable.
Test Impact
N/A
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main