Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix layout for token disabled warning #3595

Conversation

ashley-o0o
Copy link
Contributor

@ashley-o0o ashley-o0o commented Dec 19, 2024

Closes: RHOAIENG-5256

Description

Fixes the layout for the token disabled warning. It will now be on the right, inline with the token authentication, instead of below.

How Has This Been Tested?

Tested locally on cluster.

  • Navigate to the models tab in your data science project.
  • Deploy a model with tokens disabled
  • Inspect the model to see the change in layout

Test Impact

No tests changed

Screenshots

Before:
Screenshot 2024-12-19 at 9 59 33 AM

After:
Screenshot 2024-12-19 at 9 59 09 AM

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@ashley-o0o ashley-o0o force-pushed the 5256/token-section-layout branch from 09da339 to cf92d0d Compare December 19, 2024 15:26
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 85.17%. Comparing base (548ad3d) to head (cf92d0d).
Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
...s/KServeSection/KServeInferenceServiceTableRow.tsx 66.66% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3595      +/-   ##
==========================================
- Coverage   85.18%   85.17%   -0.01%     
==========================================
  Files        1380     1393      +13     
  Lines       31542    31942     +400     
  Branches     8818     8958     +140     
==========================================
+ Hits        26869    27208     +339     
- Misses       4673     4734      +61     
Files with missing lines Coverage Δ
...s/KServeSection/KServeInferenceServiceTableRow.tsx 96.15% <66.66%> (-3.85%) ⬇️

... and 53 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47f520e...cf92d0d. Read the comment docs.

@ashley-o0o ashley-o0o force-pushed the 5256/token-section-layout branch from cf92d0d to 622daf0 Compare January 7, 2025 18:22
@christianvogt
Copy link
Contributor

/lgtm
/approve

Copy link
Contributor

openshift-ci bot commented Jan 9, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Jan 9, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 990aabd into opendatahub-io:main Jan 9, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants