Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the fully qualified name window.location.host and not just location.host #3602

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jiridanek
Copy link
Member

@jiridanek jiridanek commented Dec 20, 2024

Description

I was trying some things with jest and babel, and I encountered the following error when trying to compile the frontend code

ReferenceError: location is not defined

The Dashboard code is not suffering from this, because

  1. location is defined as a global in the actual browsers
  2. the Jest config defines testEnvironment: 'jest-environment-jsdom', and besides sprucing up the runtime env, this also (somehow) instructs babel to assume browser env

I want to compile without defining testEnvironment, and since there is no harm in referencing location though window, why not just do it that way?

How Has This Been Tested?

GitHub Actions

Test Impact

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

Copy link
Contributor

openshift-ci bot commented Dec 20, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign manosnoam for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.31%. Comparing base (0f2b4f8) to head (0e94df1).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3602   +/-   ##
=======================================
  Coverage   85.30%   85.31%           
=======================================
  Files        1395     1395           
  Lines       32047    32047           
  Branches     8983     8983           
=======================================
+ Hits        27338    27341    +3     
+ Misses       4709     4706    -3     
Files with missing lines Coverage Δ
frontend/src/utilities/const.ts 100.00% <100.00%> (ø)

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f2b4f8...0e94df1. Read the comment docs.

…ation.host`

I was trying some things with jest and babel, and I encountered the following error when trying to compile the frontend code

```
ReferenceError: location is not defined
```

The Dashboard code is not suffering from this, because
1. `location` is defined as a global in the actual browsers
2. the Jest config defines `testEnvironment: 'jest-environment-jsdom',` and that (somehow) instructs babel to assume browser env

I want to compile without defining `testEnvironment`, and since there is no harm in referencing `location` though `window`, why not just do it that way?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant