Use the fully qualified name window.location.host
and not just location.host
#3602
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I was trying some things with jest and babel, and I encountered the following error when trying to compile the frontend code
The Dashboard code is not suffering from this, because
location
is defined as a global in the actual browserstestEnvironment: 'jest-environment-jsdom',
and besides sprucing up the runtime env, this also (somehow) instructs babel to assume browser envI want to compile without defining
testEnvironment
, and since there is no harm in referencinglocation
thoughwindow
, why not just do it that way?How Has This Been Tested?
GitHub Actions
Test Impact
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main