Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding links, and breaking down onboarding steps #3606

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

bobbravo2
Copy link
Member

@bobbravo2 bobbravo2 commented Dec 23, 2024

Description

Onboarding doc considerations, https://issues.redhat.com/browse/RHOAIENG-17027
This is to help new team members get an ext cluster configured with the frontend, to align the UI efforts with the broader infrastructure and RBAC changes that are planned for Q1.

How Has This Been Tested?

Local environment, validated the frontend against multiple backend clusters, via oc login and then cd frontend && npm start:dev:ext

Test Impact

No tests added due to this being primarily markdown and documentation updates for local development.

Request review criteria:

Reviewing the docs for clarity, as well as potential backend/or other test-cases for local DevEx would be very much appreciated!

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:
N/A

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@openshift-ci openshift-ci bot requested review from alexcreasy and mturley December 23, 2024 16:48
Copy link
Contributor

openshift-ci bot commented Dec 23, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign mturley for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Dec 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.13%. Comparing base (ca83e34) to head (9b23056).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3606      +/-   ##
==========================================
- Coverage   85.15%   85.13%   -0.02%     
==========================================
  Files        1395     1395              
  Lines       32041    32041              
  Branches     8979     8979              
==========================================
- Hits        27283    27278       -5     
- Misses       4758     4763       +5     

see 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca83e34...9b23056. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant