Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHOAIENG-14622: Update references of token authorization to authentication #654

Merged
merged 2 commits into from
Feb 17, 2025

Conversation

syaseen-rh
Copy link
Contributor

Description

The token authorization UI option has been updated to token authentication. Updating affected modules to reflect this change.

How Has This Been Tested?

Local build

Copy link
Contributor

@aduquett aduquett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question, otherwise LGTM.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this file intentionally excluded from the upstream docs? I noticed it is downstream but not upstream.

@@ -26,17 +26,17 @@ endif::[]
* You have enabled the single-model serving platform.
ifdef::self-managed[]
ifndef::disconnected[]
* To enable token authorization and external model routes for deployed models, you have added Authorino as an authorization provider. For more information, see link:{rhoaidocshome}{default-format-url}/installing_and_uninstalling_{url-productname-short}/installing-the-single-model-serving-platform_component-install#adding-an-authorization-provider_component-install[Adding an authorization provider for the single-model serving platform].
* To enable token authentication and external model routes for deployed models, you have added Authorino as an authentication provider. For more information, see link:{rhoaidocshome}{default-format-url}/installing_and_uninstalling_{url-productname-short}/installing-the-single-model-serving-platform_component-install#adding-an-authentication-provider_component-install[Adding an authentication provider for the single-model serving platform].
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to reviewer: The adding-an-authentication-provider_component-install module is only available downstream. It will be renamed once I fetch changes downstream.

@syaseen-rh syaseen-rh merged commit 050756d into opendatahub-io:main Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants