Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve gc service/action #1656

Merged
merged 4 commits into from
Feb 12, 2025

Improve error handling

478641a
Select commit
Loading
Failed to load commit list.
Merged

Improve gc service/action #1656

Improve error handling
478641a
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Feb 12, 2025 in 0s

20.32% (-0.02%) compared to 39da621

View this Pull Request on Codecov

20.32% (-0.02%) compared to 39da621

Details

Codecov Report

Attention: Patch coverage is 14.73684% with 81 lines in your changes missing coverage. Please review.

Project coverage is 20.32%. Comparing base (39da621) to head (478641a).

Files with missing lines Patch % Lines
pkg/services/gc/gc.go 0.00% 75 Missing ⚠️
pkg/controller/actions/gc/action_gc.go 64.70% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1656      +/-   ##
==========================================
- Coverage   20.33%   20.32%   -0.02%     
==========================================
  Files         163      163              
  Lines       11164    11195      +31     
==========================================
+ Hits         2270     2275       +5     
- Misses       8657     8682      +25     
- Partials      237      238       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.