Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add trustyai drift test #24

Open
wants to merge 39 commits into
base: main
Choose a base branch
from

Conversation

adolfo-ab
Copy link
Contributor

Add the first TrustyAI test for drift metrics

Description

This is the first test in a test class that will contain several test functions validating all the basic operations that TrustyAIService can perform wrt drift metrics

How Has This Been Tested?

Running the test against a dev cluster. This PR can be tested by checking it out and running the test with pytest.

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

tests/conftest.py Outdated Show resolved Hide resolved
tests/trustyai/conftest.py Show resolved Hide resolved
tests/trustyai/conftest.py Outdated Show resolved Hide resolved
tests/trustyai/conftest.py Outdated Show resolved Hide resolved
tests/trustyai/conftest.py Outdated Show resolved Hide resolved
tests/trustyai/drift/utils.py Outdated Show resolved Hide resolved
tests/trustyai/drift/utils.py Outdated Show resolved Hide resolved
tests/trustyai/drift/utils.py Outdated Show resolved Hide resolved
tests/trustyai/drift/utils.py Outdated Show resolved Hide resolved
tests/trustyai/drift/utils.py Outdated Show resolved Hide resolved
tests/conftest.py Outdated Show resolved Hide resolved
tests/trustyai/conftest.py Show resolved Hide resolved
tests/trustyai/conftest.py Outdated Show resolved Hide resolved
tests/trustyai/conftest.py Show resolved Hide resolved
tests/trustyai/conftest.py Outdated Show resolved Hide resolved
tests/trustyai/conftest.py Show resolved Hide resolved
tests/trustyai/conftest.py Show resolved Hide resolved
tests/trustyai/drift/conftest.py Outdated Show resolved Hide resolved
tests/trustyai/drift/utils.py Outdated Show resolved Hide resolved
Comment on lines +72 to +76
updated_cm = update_configmap_data(configmap=cm, data=data)
yield cm
if updated_cm:
updated_cm.restore()

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use ResourceEditor

raise ValueError(f"Unsupported HTTP method: {method}")


def get_trustyai_model_metadata(client: DynamicClient, token: str, trustyai_service: TrustyAIService) -> Any:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's talk bout this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants