generated from RedHatQE/python-template-repository
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add trustyai drift test #24
Open
adolfo-ab
wants to merge
39
commits into
opendatahub-io:main
Choose a base branch
from
adolfo-ab:add-trustyai-drift-test
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
rnetser
requested changes
Nov 6, 2024
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
rnetser
requested changes
Nov 10, 2024
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
rnetser
requested changes
Nov 13, 2024
Comment on lines
+72
to
+76
updated_cm = update_configmap_data(configmap=cm, data=data) | ||
yield cm | ||
if updated_cm: | ||
updated_cm.restore() | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please use ResourceEditor
raise ValueError(f"Unsupported HTTP method: {method}") | ||
|
||
|
||
def get_trustyai_model_metadata(client: DynamicClient, token: str, trustyai_service: TrustyAIService) -> Any: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's talk bout this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the first TrustyAI test for drift metrics
Description
This is the first test in a test class that will contain several test functions validating all the basic operations that TrustyAIService can perform wrt drift metrics
How Has This Been Tested?
Running the test against a dev cluster. This PR can be tested by checking it out and running the test with pytest.
Merge criteria: