Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fms-hf-tuning e2e test #9

Open
wants to merge 6 commits into
base: dev
Choose a base branch
from

Conversation

tedhtchang
Copy link
Member

@tedhtchang tedhtchang commented Apr 8, 2024

What this PR does / why we need it:

Update the e2e test to adapt the new fms-hf-tuning image

How to test:

git clone --single-branch --branch update-fms-hf-tuning-e2e-test https://github.com/tedhtchang/training-operator.git
cd training-operator/
test/e2e/kind.sh
test/e2e/setup.sh
git clone --single-branch --branch add-kueue-testclient https://github.com/tedhtchang/codeflare-common.git
go mod edit --replace github.com/project-codeflare/codeflare-common=./codeflare-common
CODEFLARE_TEST_TIMEOUT_LONG=10m go test -count=1 -tags=tuning_e2e ./test/e2e
# Note: The idiomatic way to disable test caching explicitly is to use -count=1

@tedhtchang tedhtchang force-pushed the update-fms-hf-tuning-e2e-test branch 2 times, most recently from ed81773 to 1eb5fb1 Compare April 9, 2024 18:33
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8620627666

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 6 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.07%) to 42.785%

Files with Coverage Reduction New Missed Lines %
pkg/controller.v1/mpi/mpijob_controller.go 6 80.48%
Totals Coverage Status
Change from base Build 8601208172: -0.07%
Covered Lines: 3745
Relevant Lines: 8753

💛 - Coveralls

@tedhtchang
Copy link
Member Author

tedhtchang commented Apr 10, 2024

@astefanutti The upstream upgrade to go 1.22 so we may need to rebase the dev branch before we can pass the tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants