Skip to content

Commit

Permalink
gha: override vLLM version in nox with env var
Browse files Browse the repository at this point in the history
  • Loading branch information
dtrifiro committed Jul 5, 2024
1 parent 509115b commit f86341d
Showing 1 changed file with 3 additions and 9 deletions.
12 changes: 3 additions & 9 deletions .github/workflows/tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ jobs:
os: [ubuntu-latest]
pyv: ["3.11"]
vllm_version:
# - "pypi" # skip the pypi version as it will not work with CPU
# - "" # skip the pypi version as it will not work on CPU
- "git+https://github.com/vllm-project/[email protected]"
- "git+https://github.com/vllm-project/vllm@main"
- "git+https://github.com/opendatahub-io/vllm@main"
Expand Down Expand Up @@ -60,19 +60,13 @@ jobs:
pip --version
nox --version
- name: Set custom vllm version
if: ${{ matrix.vllm_version != 'pypi' }}
run: |
vllm_version="vllm@${{matrix.vllm_version}}"
echo "Using vllm@${vllm_version}"
sed -i "s|\"vllm.*\",|\"${vllm_version}\",|g" pyproject.toml
- name: Lint code and check dependencies
run: nox -s lint-${{ matrix.pyv }}

- name: Run tests
run: nox -s tests-${{ matrix.pyv }} -- --cov-report=xml
env:
VLLM_VERSION_OVERRIDE: ${{ matrix.vllm_version }}

- name: Upload coverage report
uses: codecov/codecov-action@v4
Expand Down

0 comments on commit f86341d

Please sign in to comment.