Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ invoke caikit -> peft conversion at load time #161

Merged
merged 6 commits into from
Oct 11, 2024
Merged

Conversation

joerunde
Copy link
Contributor

Description

This creates new tempdirs and invokes the caikit to peft conversion utility at prompt adapter load time when a decoder.pt format model is detected.

How Has This Been Tested?

Loaded up onto a dev pod and tested with the bloom_sentiment_1 fixture that was added with the conversion utility. Seems to work fine!

Need to add a unit test for this specifically, still have to get nox up and running locally. Opening this PR now for feedback.

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@codecov-commenter
Copy link

codecov-commenter commented Oct 10, 2024

Codecov Report

Attention: Patch coverage is 96.80851% with 3 lines in your changes missing coverage. Please review.

Project coverage is 61.66%. Comparing base (a3620be) to head (95b2064).

Files with missing lines Patch % Lines
...lm_tgis_adapter/tgis_utils/convert_pt_to_prompt.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #161      +/-   ##
==========================================
+ Coverage   58.40%   61.66%   +3.26%     
==========================================
  Files          27       28       +1     
  Lines        1618     1693      +75     
  Branches      207      208       +1     
==========================================
+ Hits          945     1044      +99     
+ Misses        581      553      -28     
- Partials       92       96       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joerunde joerunde added this pull request to the merge queue Oct 11, 2024
@joerunde joerunde removed this pull request from the merge queue due to a manual request Oct 11, 2024
Signed-off-by: Joe Runde <[email protected]>
@joerunde joerunde enabled auto-merge October 11, 2024 17:22
@joerunde joerunde added this pull request to the merge queue Oct 11, 2024
Merged via the queue into main with commit 44cc0d5 Oct 11, 2024
3 checks passed
@joerunde joerunde deleted the load-caikit-prompts branch October 11, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants