Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: duplicate stacktrace on engine error #171

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

wallashss
Copy link
Contributor

Description

This is a follow up on this change vllm-project/vllm#9023 of vllm upstream

How Has This Been Tested?

See vllm-project/vllm#9023

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@codecov-commenter
Copy link

codecov-commenter commented Oct 22, 2024

Codecov Report

Attention: Patch coverage is 95.65217% with 1 line in your changes missing coverage. Please review.

Project coverage is 62.46%. Comparing base (d66fff7) to head (199962e).

Files with missing lines Patch % Lines
tests/test_grpc_server.py 94.73% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #171      +/-   ##
==========================================
+ Coverage   61.54%   62.46%   +0.92%     
==========================================
  Files          28       28              
  Lines        1698     1721      +23     
  Branches      210      211       +1     
==========================================
+ Hits         1045     1075      +30     
+ Misses        556      544      -12     
- Partials       97      102       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dtrifiro dtrifiro added this pull request to the merge queue Oct 24, 2024
Merged via the queue into opendatahub-io:main with commit 23ae5db Oct 24, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants