-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: remove grpcio-tools build time dependency #230
base: main
Are you sure you want to change the base?
Conversation
745f0a7
to
0a106b0
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #230 +/- ##
=======================================
Coverage 63.46% 63.46%
=======================================
Files 28 28
Lines 1768 1768
Branches 219 219
=======================================
Hits 1122 1122
Misses 541 541
Partials 105 105 ☔ View full report in Codecov by Sentry. |
0a106b0
to
a442404
Compare
@dtrifiro , if we build grpcio-tools from scratch it will take alot of time as suggested in the pr, but for s390x we install the package with one env variable. Using this variable installation will take max 5 mins ![]() Note: grpcio-tools took only 1-2 mins to build rest of time is taken by grpcio |
after this vlllm-tgis-adapter is getting installed successfully after on s390x |
@dtrifiro one more observation I have made for s390x is that during |
These packages are being installed
|
setup.py `grpcio-tools` is not available as a wheel for some platforms, making building vllm-tgis-adapter require building `grpcio-tools` from scratch. Since this is not always possible, and is quite time consuming, we just include the generated code in the repo.
a442404
to
3a03dd5
Compare
@joerunde could you take a look? I don't see any potential issues with doing this apart from the annoyance of having to commit the generated Note: I'm not a big fan of introducing generated code in the repo and/or manual steps in the build process, so the alternative of using |
grpcio-tools
is not available as a wheel for some platforms, making buildingvllm-tgis-adapter
require buildinggrpcio-tools
from scratch.Since this is not always possible (e.g. bazel not available on rhel), and is quite time consuming, we just include the generated code in the repo.
Note: this could (should?) also be added as a pre-commit hook, although this might slow down development a bit, so I left this as a gha step, for now.