Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: usage of a deprecated Node.js version in CI #687

Open
wants to merge 5 commits into
base: dev
Choose a base branch
from

Conversation

hamirmahal
Copy link

fixes #686.

Motivation

.github/workflows/update_base.yml uses a deprecated Node.js version.

Modification

.github/workflows/update_base.yml no longer uses a deprecated Node.js version

BC-breaking (Optional)

Does the modification introduce changes that break the backward compatibility of the downstream repositories?

No.

Checklist

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects.
  • CLA has been signed and all committers have signed the CLA in this PR.

icecraft and others added 5 commits September 12, 2024 14:12
Copy link
Contributor

github-actions bot commented Oct 5, 2024

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@hamirmahal
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

github-actions bot added a commit that referenced this pull request Oct 5, 2024
echo "start test"

- name: update-base
uses: actions/checkout@v4
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the latest major version at the time of this writing.

@drunkpig drunkpig requested a review from dt-yy October 24, 2024 11:13
@drunkpig drunkpig changed the base branch from master to dev October 24, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.github/workflows/update_base.yml uses a deprecated Node.js version
2 participants