Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OO-ify the code generation code #168

Merged
merged 16 commits into from
Nov 20, 2024
Merged

OO-ify the code generation code #168

merged 16 commits into from
Nov 20, 2024

Conversation

mccalluc
Copy link
Contributor

@mccalluc mccalluc commented Nov 19, 2024

For the reviewer:

  • The diff is going to be hard to read, but if you just look at the result, does the code organization make sense?
  • Are there other obvious failure modes that should be tested on the templates?

@mccalluc mccalluc marked this pull request as ready for review November 19, 2024 22:17
Copy link
Collaborator

@pdurbin pdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't run the code but the new version looks fine to me.

@mccalluc mccalluc merged commit fc2aa18 into main Nov 20, 2024
2 checks passed
@mccalluc mccalluc deleted the 162-oo-templates branch November 20, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

More OO for templates In template, error if code block substitution fails
2 participants