Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explain confidence interval #169

Merged
merged 3 commits into from
Nov 21, 2024
Merged

Explain confidence interval #169

merged 3 commits into from
Nov 21, 2024

Conversation

mccalluc
Copy link
Contributor

@mccalluc mccalluc commented Nov 20, 2024 •
edited
Loading

  • Fix Explain confidence interval #153.
  • My sense is that the confidence interval is not something we want to control in the UI: It's the kind of detail that is best left for the user to tweak in the notebook.

For the reviewer:

  • Does a short comment in the UI (where we want to avoid distractions) and a longer note in the notebook (where we want to really explain things) make sense?
  • Do you think explanation is needed anywhere else? Could add a comment to the graphs, but I'd worry about clutter.

@ekraffmiller ekraffmiller self-assigned this Nov 20, 2024
ekraffmiller
ekraffmiller approved these changes Nov 21, 2024
View reviewed changes
Copy link
Member

@ekraffmiller ekraffmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think short explanation in the generated code looks good. We can wait for user feedback to see if more is needed.

@ekraffmiller ekraffmiller removed their assignment Nov 21, 2024
@mccalluc mccalluc merged commit d455df5 into main Nov 21, 2024
2 checks passed
@mccalluc mccalluc deleted the 153-explain-confidence-interval branch November 21, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekraffmiller ekraffmiller ekraffmiller approved these changes

Assignees
No one assigned
Labels
None yet
Projects
DP Wizard
Status: Complete
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Explain confidence interval
2 participants
@mccalluc @ekraffmiller