Read CSV columns from uploaded file #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekraffmiller
reviewed
Oct 7, 2024
| @@ -29,13 +37,12 @@ def get_arg_parser(): | |||
|
|
|||
| def main(): # pragma: no cover | |||
| # We call parse_args() again inside the app. | |||
| # We only call it here so "--help" is handled. | |||
| # We only call it here so "--help" is handled, | |||
| # and to validate inputs. | |||
| get_arg_parser().parse_args() | |||
There was a problem hiding this comment.
Can we also have a test that the required arguments were passed? When I run the app with no args, it shows a stack trace of an unhandled error. I read your comment about skipping this for now, but I'm not sure I understand how that helps with debugging?
|
@ekraffmiller , added assertions in the end-to-end test to make sure there are no shiny errors, and fixed the error we were seeing by just returning |
ekraffmiller
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pairs of
reactive.calcandrender.textfunctions seem redundant, but I ran into trouble when I tried to apply both decorators to one function. When I feel more confident about how I'm using the library may ask about this in one of the forums.