added comments and resolve feedback

openearth · Sep 12, 2019 · e5833a5 · e5833a5
1 parent dfc2428
commit e5833a5
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/components/graph-line.vue b/components/graph-line.vue
@@ -150,6 +150,10 @@ export default {
     type: {
       type: String,
       default: 'line',
+      validator: function(value) {
+        // The value must match one of these strings
+        return ['line', 'scatter'].indexOf(value) !== -1
+      },
     },
   },
   data: () => ({

diff --git a/layouts/default.vue b/layouts/default.vue
@@ -173,10 +173,14 @@ export default {
       return layer
     },
     selectLocations(detail) {
+      // On the selection (by mouse event on map) of a location update the
+      // route accordingly
       this.geometry = detail.geometry
       const { datasetIds } = this.$route.params
       const locationIds = []
       detail.features.forEach(feature => {
+        // When a layer has a metadata with locationIdField use this layer and
+        // get the locationId usin this field
         const locId = _.get(feature, 'layer.metadata.locationIdField')
         if (locId) {
           locationIds.push(feature.properties[locId])
@@ -228,6 +232,7 @@ export default {
       this.updateRoute(newRouteObject)
     },
     updateRoute(routeObj) {
+      // Update route with route object
       const { datasetIds, locationId } = routeObj.params
       if (datasetIds === undefined) {
         this.geometry = {