Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(api): adding v1 CRDs #167

Merged
merged 2 commits into from
Nov 25, 2021
Merged

feat(api): adding v1 CRDs #167

merged 2 commits into from
Nov 25, 2021

Conversation

shubham14bajpai
Copy link
Contributor

@shubham14bajpai shubham14bajpai commented Nov 9, 2021 •
edited
Loading

Why is this PR required? What issue does it fix?:
This PR updates the jiva CRDs to v1 version. It also updates the go version to 1.16
_Fixes #160

Does this PR require any upgrade changes?:
No, as

  • there is no schema change involved and
  • the CRDs serves both v1 and v1alpha1 k8s takes care of converting the operators call the specific version of the CR.

Verified the same.

If the changes in this PR are manually verified, list down the scenarios covered::

Any additional information for your reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs

Checklist:

  • PR Title follows the convention of <type>(<scope>): <subject>.
  • Has the change log section been updated?
  • Commit has unit tests
  • Commit has integration tests
  • (Optional) Does this PR change require updating Helm Chart? If yes, mention the Helm Chart PR #
  • (Optional) Are upgrade changes included in this PR? If not, mention the issue/PR to track:
  • (Optional) If documentation changes are required, which issue https://github.com/openebs/website is used to track them:

@shubham14bajpai shubham14bajpai changed the title V1 feat(api): adding v1 CRDs Nov 9, 2021
This was linked to issues Nov 9, 2021
Refactor k8s builders to use openebs/api #163
Open
Move jivaVolume and jivaVolumePolicy CRDs to v1 #160
Closed
@shubham14bajpai shubham14bajpai marked this pull request as ready for review November 9, 2021 06:35
@shubham14bajpai shubham14bajpai removed a link to an issue Nov 9, 2021
Refactor k8s builders to use openebs/api #163
Open
@shubham14bajpai shubham14bajpai requested a review from kmova November 9, 2021 06:57
@kmova kmova merged commit 66206ef into openebs-archive:develop Nov 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rajaSahil rajaSahil rajaSahil approved these changes

@kmova kmova kmova approved these changes

@mittachaitu mittachaitu Awaiting requested review from mittachaitu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move jivaVolume and jivaVolumePolicy CRDs to v1
3 participants
@shubham14bajpai @kmova @rajaSahil