chore(helm): Adds custom iSCSIadm ConfigMap and HostPID options #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tackles issue openebs-archive#207. Adds the ability to enable HostPID: true for the csi Node DaemonSet. It also adds the ability to inject a custom configuration in to the hardcoded `openebs-jiva-csi-iscsiadm` ConfigMap. These changes are pretty small but ensures that the Jiva Operator can more easily be used with (Talos)[https://www.talos.dev/]. Talos requires some modifications for it to work properly with Talos. Details here: https://www.talos.dev/v1.6/kubernetes-guides/configuration/replicated-local-storage-with-openebs-jiva/#patching-the-jiva-installation Signed-off-by: Leo Palmer Sunmo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why is this PR required? What issue does it fix?:
Fixes #207
What this PR does?:
Adds the ability to enable HostPID: true for the csi Node DaemonSet. It also adds the ability to inject a custom configuration in to the hardcoded
openebs-jiva-csi-iscsiadmConfigMap.These changes are pretty small but ensures that the Jiva Operator can more easily be used with (Talos)[https://www.talos.dev/]. Talos requires some modifications for it to work properly with Talos. Details here: https://www.talos.dev/v1.6/kubernetes-guides/configuration/replicated-local-storage-with-openebs-jiva/#patching-the-jiva-installation
Does this PR require any upgrade changes?:
No, it's only Helm Chart changes.
If the changes in this PR are manually verified, list down the scenarios covered::
I ran
helm templatelocally with the two added variables provided and left blank to make sure the behaviour makes sense.Any additional information for your reviewer? :
I did not touch the chart version, as it seems you keep it in lock-step with the actual Jiva Operator version, so I left that up to you guys. I'm happy to bump the version (3.6.1 for example) before merging if that's easier though.
I also did not add anything to the CHANGELOG.md file for the same reason.
Checklist:
<type>(<scope>): <subject>.