fix(manager): disable metrics server from controller runtime

latest controller runtime started a metrics server at port 8080 by default. This caused NDM to crash on systems where the port was already in use. Signed-off-by: Akhil Mohan <[email protected]>
openebs-archive · Aug 11, 2020 · 07dc984 · 07dc984
1 parent dc29f7c
commit 07dc984
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/changelogs/unreleased/473-akhilerm b/changelogs/unreleased/473-akhilerm
@@ -0,0 +1 @@
+disable metrics server of controller runtime by default.
diff --git a/cmd/manager/main.go b/cmd/manager/main.go
@@ -100,7 +100,7 @@ func main() {
 	reconInterval := ReconciliationInterval
 
 	// Create a new Cmd to provide shared dependencies and start components
-	mgr, err := manager.New(cfg, manager.Options{Namespace: namespace, SyncPeriod: &reconInterval})
+	mgr, err := manager.New(cfg, manager.Options{Namespace: namespace, SyncPeriod: &reconInterval, MetricsBindAddress: "0"})
 	if err != nil {
 		klog.Errorf("Failed to create a new manager: %v", err)
 		os.Exit(1)

diff --git a/cmd/ndm_daemonset/controller/controller.go b/cmd/ndm_daemonset/controller/controller.go
@@ -132,7 +132,7 @@ func NewController() (*Controller, error) {
 	}
 	controller.Namespace = ns
 
-	mgr, err := manager.New(controller.config, manager.Options{Namespace: controller.Namespace})
+	mgr, err := manager.New(controller.config, manager.Options{Namespace: controller.Namespace, MetricsBindAddress: "0"})
 	if err != nil {
 		return controller, err
 	}
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		disable metrics server of controller runtime by default.