Skip to content

Commit

Permalink
fix(build): add context to workflow (#554)
Browse files Browse the repository at this point in the history
- add context to workflow
- remove RELEASE_TAG from makefile variables

Signed-off-by: Akhil Mohan <[email protected]>
  • Loading branch information
akhilerm authored Mar 9, 2021
1 parent 725828a commit c774303
Show file tree
Hide file tree
Showing 4 changed files with 14 additions and 1 deletion.
5 changes: 5 additions & 0 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,7 @@ jobs:
- name: Build & Push Image
uses: docker/build-push-action@v2
with:
context: .
file: ./build/ndm-daemonset/Dockerfile
push: true
platforms: linux/amd64, linux/arm64, linux/arm/v7, linux/ppc64le
Expand Down Expand Up @@ -205,6 +206,7 @@ jobs:
- name: Build & Push Image
uses: docker/build-push-action@v2
with:
context: .
file: ./build/ndm-exporter/Dockerfile
push: true
platforms: linux/amd64, linux/arm64, linux/arm/v7, linux/ppc64le
Expand Down Expand Up @@ -286,6 +288,7 @@ jobs:
- name: Build & Push Image
uses: docker/build-push-action@v2
with:
context: .
file: ./build/ndm-operator/Dockerfile
push: true
platforms: linux/amd64, linux/arm64, linux/arm/v7, linux/ppc64le
Expand Down Expand Up @@ -323,6 +326,7 @@ jobs:
- name: Build Node Disk Manager
uses: docker/build-push-action@v2
with:
context: .
file: ./build/ndm-daemonset/Dockerfile
push: false
load: true
Expand All @@ -333,6 +337,7 @@ jobs:
- name: Build Node Disk Operator
uses: docker/build-push-action@v2
with:
context: .
file: ./build/ndm-operator/Dockerfile
push: false
load: true
Expand Down
5 changes: 5 additions & 0 deletions .github/workflows/pull_request.yml
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,7 @@ jobs:
- name: Build & Push Image
uses: docker/build-push-action@v2
with:
context: .
file: ./build/ndm-daemonset/Dockerfile
push: false
platforms: linux/amd64, linux/arm64, linux/arm/v7, linux/ppc64le
Expand Down Expand Up @@ -109,6 +110,7 @@ jobs:
- name: Build & Push Image
uses: docker/build-push-action@v2
with:
context: .
file: ./build/ndm-exporter/Dockerfile
push: false
platforms: linux/amd64, linux/arm64, linux/arm/v7, linux/ppc64le
Expand Down Expand Up @@ -136,6 +138,7 @@ jobs:
- name: Build & Push Image
uses: docker/build-push-action@v2
with:
context: .
file: ./build/ndm-operator/Dockerfile
push: false
platforms: linux/amd64, linux/arm64, linux/arm/v7, linux/ppc64le
Expand Down Expand Up @@ -169,6 +172,7 @@ jobs:
- name: Build Node Disk Manager
uses: docker/build-push-action@v2
with:
context: .
file: ./build/ndm-daemonset/Dockerfile
push: false
load: true
Expand All @@ -179,6 +183,7 @@ jobs:
- name: Build Node Disk Operator
uses: docker/build-push-action@v2
with:
context: .
file: ./build/ndm-operator/Dockerfile
push: false
load: true
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,7 @@ jobs:
- name: Build & Push Image
uses: docker/build-push-action@v2
with:
context: .
file: ./build/ndm-daemonset/Dockerfile
push: true
platforms: linux/amd64, linux/arm64, linux/arm/v7, linux/ppc64le
Expand Down Expand Up @@ -162,6 +163,7 @@ jobs:
- name: Build & Push Image
uses: docker/build-push-action@v2
with:
context: .
file: ./build/ndm-exporter/Dockerfile
push: true
platforms: linux/amd64, linux/arm64, linux/arm/v7, linux/ppc64le
Expand Down Expand Up @@ -239,6 +241,7 @@ jobs:
- name: Build & Push Image
uses: docker/build-push-action@v2
with:
context: .
file: ./build/ndm-operator/Dockerfile
push: true
platforms: linux/amd64, linux/arm64, linux/arm/v7, linux/ppc64le
Expand Down
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ ifeq (${DBUILD_SITE_URL}, )
export DBUILD_SITE_URL
endif

export DBUILD_ARGS=--build-arg DBUILD_DATE=${DBUILD_DATE} --build-arg DBUILD_REPO_URL=${DBUILD_REPO_URL} --build-arg DBUILD_SITE_URL=${DBUILD_SITE_URL} --build-arg RELEASE_TAG=${RELEASE_TAG}
export DBUILD_ARGS=--build-arg DBUILD_DATE=${DBUILD_DATE} --build-arg DBUILD_REPO_URL=${DBUILD_REPO_URL} --build-arg DBUILD_SITE_URL=${DBUILD_SITE_URL}

# Initialize the NDM DaemonSet variables
# Specify the NDM DaemonSet binary name
Expand Down

0 comments on commit c774303

Please sign in to comment.