Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

integration-test #653

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

integration-test #653

wants to merge 1 commit into from

Conversation

Nivedita-coder
Copy link

Addresses the following issues: #316
Signed-off-by: Nivedita Prasad [email protected]

@Nivedita-coder
Copy link
Author

The blockdevices on path /dev/sdb /dev/sda is in inactive status, here are the outputs:

kubectl get bd -n openebs -o wide
NAME                                           NODENAME                           PATH        FSTYPE   SIZE           CLAIMSTATE   STATUS     AGE
blockdevice-18d185d10824b64718b1810910d14c25   lenovo-ideapad-l340-15irh-gaming   /dev/sdb    vfat     7750287360     Unclaimed    Inactive   35h
blockdevice-062f9e63a8f738c5c80a8dd9c76da379   lenovo-ideapad-l340-15irh-gaming   /dev/sda3   ntfs     998864060416   Unclaimed    Inactive   35h
blockdevice-f6de9bcc39618e718d875ea8819914e6   lenovo-ideapad-l340-15irh-gaming   /dev/sda2            16777216       Unclaimed    Inactive   35h
blockdevice-5b37fad69bea6352f6c107c555acdce0   lenovo-ideapad-l340-15irh-gaming   /dev/sda1   vfat     272629760      Unclaimed    Inactive   35h
blockdevice-38b0bba94a9f1313fcb344c725869d5e   lenovo-ideapad-l340-15irh-gaming   /dev/sda4   ntfs     1048576000     Unclaimed    Inactive   35h

@Nivedita-coder
integration-test
05149dc 
Signed-off-by: Nivedita-coder <[email protected]>
akhilerm
akhilerm reviewed Oct 18, 2021
View reviewed changes
deploy/ndm-operator.yaml
@@ -435,7 +435,7 @@ data:
name: path filter
state: true
include: ""
exclude: "/dev/loop,/dev/fd0,/dev/sr0,/dev/ram,/dev/md,/dev/dm-,/dev/rbd,/dev/zd"
exclude: "/dev/loop,/dev/fd0,/dev/sr0,/dev/ram,/dev/md,/dev/dm-,/dev/rbd,/dev/zd,/dev/sda,/dev/sdb"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does this change, helps in the integration test path filter. ?

@codecov-commenter
Copy link

Codecov Report

Merging #653 (05149dc) into develop (9fe3968) will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #653      +/-   ##
===========================================
- Coverage    46.09%   46.04%   -0.06%     
===========================================
  Files           78       78              
  Lines         3820     3820              
===========================================
- Hits          1761     1759       -2     
- Misses        1901     1903       +2     
  Partials       158      158
Impacted Files Coverage Δ
cmd/ndm_daemonset/probe/udevprobe.go 47.43% <0.00%> (-0.80%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fe3968...05149dc. Read the comment docs.

@akhilerm
Copy link
Contributor

@Nivedita-coder Are there any updates on this PR?

@Nivedita-coder
Copy link
Author

@Nivedita-coder Are there any updates on this PR?

Hey @akhilerm, writing the integration test, will make the PR by this week.
Thanks!

@z0marlin
Copy link
Contributor

Hey @Nivedita-coder, are there any updates to this PR?

@akhilerm
Copy link
Contributor

akhilerm commented Mar 2, 2022

@Nivedita-coder Are there any updates on this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akhilerm akhilerm akhilerm left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Nivedita-coder @codecov-commenter @akhilerm @z0marlin