Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(charts): disable hostNetwork on node plugin #280

Closed
wants to merge 1 commit into from
Closed

feat(charts): disable hostNetwork on node plugin #280

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion deploy/helm/charts/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
apiVersion: v2
name: lvm-localpv
description: CSI Driver for dynamic provisioning of LVM Persistent Local Volumes.
version: 1.4.0
version: 1.4.1
appVersion: 1.4.0
icon: https://raw.githubusercontent.com/cncf/artwork/master/projects/openebs/icon/color/openebs-icon-color.png
home: https://openebs.io/
Expand Down
2 changes: 1 addition & 1 deletion deploy/helm/charts/templates/lvm-node.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ spec:
priorityClassName: {{ template "lvmlocalpv.lvmNode.priorityClassName" . }}
{{- end }}
serviceAccountName: {{ .Values.serviceAccount.lvmNode.name }}
hostNetwork: true
hostNetwork: {{ .Values.lvmNode.hostNetwork }}
containers:
- name: {{ .Values.lvmNode.driverRegistrar.name }}
image: "{{ .Values.lvmNode.driverRegistrar.image.registry }}{{ .Values.lvmNode.driverRegistrar.image.repository }}:{{ .Values.lvmNode.driverRegistrar.image.tag }}"
Expand Down
2 changes: 1 addition & 1 deletion deploy/helm/charts/templates/psp.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ spec:
allowPrivilegeEscalation: true
allowedCapabilities: ['*']
volumes: ['*']
hostNetwork: true
hostNetwork: {{ .Values.lvmNode.hostNetwork}}
hostIPC: true
hostPID: true
runAsUser:
Expand Down
2 changes: 2 additions & 0 deletions deploy/helm/charts/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,8 @@ lvmNode:
# Configure the maximum number of queries allowed after
# accounting for rolled over qps from previous seconds.
burst: 0
# Disable or enable the use of hostNetwork for the lvm node daemonset.
hostNetwork: false


# lvmController contains the configurables for
Expand Down
1 change: 0 additions & 1 deletion deploy/lvm-operator.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1633,7 +1633,6 @@ spec:
spec:
priorityClassName: openebs-lvm-localpv-csi-node-critical
serviceAccountName: openebs-lvm-node-sa
hostNetwork: true
containers:
- name: csi-node-driver-registrar
image: registry.k8s.io/sig-storage/csi-node-driver-registrar:v2.8.0
Expand Down
1 change: 0 additions & 1 deletion deploy/yamls/lvm-driver.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1197,7 +1197,6 @@ spec:
spec:
priorityClassName: openebs-lvm-localpv-csi-node-critical
serviceAccountName: openebs-lvm-node-sa
hostNetwork: true
containers:
- name: csi-node-driver-registrar
image: registry.k8s.io/sig-storage/csi-node-driver-registrar:v2.8.0
Expand Down
Loading