Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test creating sized snapshots for filesystem and block volumes #309

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

dsharma-dc
Copy link
Contributor

Pull Request template

Please, go through these steps before you submit a PR.

Why is this PR required? What issue does it fix?:
Exercises the snapSize behaviour of volume snapshot class.

What this PR does?:
Tests creating sized snapshots for filesystem and raw block volumes.

Does this PR require any upgrade changes?:
No

If the changes in this PR are manually verified, list down the scenarios covered::

Any additional information for your reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs

Checklist:

  • Fixes #
  • PR Title follows the convention of <type>(<scope>): <subject>
  • Has the change log section been updated?
  • Commit has unit tests
  • Commit has integration tests
  • (Optional) Are upgrade changes included in this PR? If not, mention the issue/PR to track:
  • (Optional) If documentation changes are required, which issue on https://github.com/openebs/openebs-docs is used to track them:

@dsharma-dc
Copy link
Contributor Author

This PR is based on top of branch used for PR 308 and hence we see that commit here as well. That commit doesn't need review against this PR.

pkg/lvm/lvm_util.go Outdated Show resolved Hide resolved
pkg/lvm/lvm_util.go Outdated Show resolved Hide resolved
pkg/lvm/lvm_util.go Outdated Show resolved Hide resolved
ci/ci-test.sh Outdated Show resolved Hide resolved
tests/utils.go Outdated Show resolved Hide resolved
tests/run_test.go Outdated Show resolved Hide resolved
@dsharma-dc dsharma-dc merged commit 45b61d1 into develop Jun 14, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants